Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute Hash for MemberMemberBinding in ExpressionEqualityComparer #17959

Closed
miegir opened this issue Sep 20, 2019 · 5 comments · Fixed by #19271
Closed

Compute Hash for MemberMemberBinding in ExpressionEqualityComparer #17959

miegir opened this issue Sep 20, 2019 · 5 comments · Fixed by #19271
Assignees
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. type-bug
Milestone

Comments

@miegir
Copy link

miegir commented Sep 20, 2019

https://github.com/aspnet/EntityFrameworkCore/blob/03503351c9dd3daf05a1ff66520c00aba3e372eb/src/EFCore/Query/Internal/ExpressionEqualityComparer.cs#L238

I think that this line is supposed to be

throw new NotImplementedException($"Unhandled binding type: {memberBinding.BindingType}");

However, textual representation of the binding (that is output currently) will be helpful too, especially because only one binding type is not supported currently.

@smitpatel
Copy link
Member

It should take care of MemberMemberBinding & throw exception for BindingType. (Follows what VisitMemberBinding does in base visitor)

@smitpatel smitpatel added the good first issue This issue should be relatively straightforward to fix. label Sep 20, 2019
@smitpatel smitpatel added this to the Backlog milestone Sep 20, 2019
@mithileshz
Copy link

I am guessing this is fixed now and isn't available to be picked up?

@ajcvickers
Copy link
Member

@smitpatel Did the PR you merged fix this issue?

@smitpatel
Copy link
Member

Error message improved. The issue is open to actually take care of MemberMemberBinding.

@smitpatel smitpatel changed the title Incorrect error message for not supported binding Compute Hash for MemberMemberBinding in ExpressionEqualityComparer Oct 15, 2019
@smitpatel
Copy link
Member

#18685

smitpatel added a commit that referenced this issue Dec 11, 2019
smitpatel added a commit that referenced this issue Dec 11, 2019
smitpatel added a commit that referenced this issue Dec 11, 2019
@smitpatel smitpatel self-assigned this Dec 12, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 12, 2019
@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 Dec 12, 2019
smitpatel added a commit that referenced this issue Dec 12, 2019
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants