-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute Hash for MemberMemberBinding in ExpressionEqualityComparer #17959
Labels
area-query
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
good first issue
This issue should be relatively straightforward to fix.
type-bug
Milestone
Comments
It should take care of MemberMemberBinding & throw exception for BindingType. (Follows what VisitMemberBinding does in base visitor) |
smitpatel
added
the
good first issue
This issue should be relatively straightforward to fix.
label
Sep 20, 2019
I am guessing this is fixed now and isn't available to be picked up? |
@smitpatel Did the PR you merged fix this issue? |
Error message improved. The issue is open to actually take care of MemberMemberBinding. |
smitpatel
changed the title
Incorrect error message for not supported binding
Compute Hash for MemberMemberBinding in ExpressionEqualityComparer
Oct 15, 2019
smitpatel
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-query
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
good first issue
This issue should be relatively straightforward to fix.
type-bug
https://github.com/aspnet/EntityFrameworkCore/blob/03503351c9dd3daf05a1ff66520c00aba3e372eb/src/EFCore/Query/Internal/ExpressionEqualityComparer.cs#L238
I think that this line is supposed to be
However, textual representation of the binding (that is output currently) will be helpful too, especially because only one binding type is not supported currently.
The text was updated successfully, but these errors were encountered: