Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimenting with TrackGraph and possibly bug? #18823

Closed
sitepodmatt opened this issue Nov 9, 2019 · 0 comments · Fixed by #19453
Closed

Experimenting with TrackGraph and possibly bug? #18823

sitepodmatt opened this issue Nov 9, 2019 · 0 comments · Fixed by #19453
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone
5.0.0

Comments

@sitepodmatt
Copy link

sitepodmatt commented Nov 9, 2019 •
edited
Loading

In EntityEntryGraphNode class with TState type parameter in EF Core 3.0

Should this have a setter? as the doc line suggests?


    /// <summary>
        ///     Gets or sets state that will be available to all nodes that are visited after this node.
        /// </summary>
        public virtual TState NodeState { get; }

I realize this class has a disclaimer about internal but Im using it from the public ChangeTracker.TrackGraph to walk the graph whilst attempting to carry my own state via NodeState, NodeState is not settable.
@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 11, 2019
@ajcvickers ajcvickers self-assigned this Nov 11, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 1, 2020
ajcvickers added a commit that referenced this issue Jan 1, 2020
@ajcvickers
Make EntityEntryGraphNode.TState mutable
06c82e5 
Fixes #18823
@ajcvickers ajcvickers mentioned this issue Jan 1, 2020
Merged
ajcvickers added a commit that referenced this issue Jan 1, 2020
@ajcvickers
Make EntityEntryGraphNode.TState mutable
e4128cb 
Fixes #18823
ajcvickers added a commit that referenced this issue Jan 3, 2020
@ajcvickers
Make EntityEntryGraphNode.TState mutable
bfd0d0e 
Fixes #18823
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Make EntityEntryGraphNode.TState mutable dotnet/efcore
2 participants
@ajcvickers @sitepodmatt