InMemory: Expansion weak entities in OrderBy/ThenBy should happen together

[smitpatel]

OrderBy_collection_count_ThenBy_reference_navigation

[RamunasAdamonis]

I ran into this issue while migrating my project from .Net Core 2.2 to .Net 5.

Following expression was working with EF Core InMemory version 2.2.3, but does not work anymore in 5.0.1 (also checked 3.1.3 not working as well).

var products = await context.Products
    .OrderBy(x => x.ProductType)
    .ThenByDescending(x => x.Price.Amount)
    .ToListAsync();

*Price is Owned entity

Same error as in #22732

[smitpatel]

new regression test

        [ConditionalTheory]
        [MemberData(nameof(IsAsyncData))]
        public virtual Task Owned_navigations_are_expanded_for_OrderBy_ThenBy_together(bool async)
        {
            return AssertQuery(
                async,
                ss => ss.Set<OwnedPerson>()
                    .OrderBy(e => e.PersonAddress.PlaceType)
                    .ThenBy(e => e.PersonAddress.Country.Name),
                assertOrder: true);
        }

Old one works correctly now since it is weak type which uses STET.

[ajcvickers]

We recommend against using the in-memory provider for testing--see Testing EF Core Applications. While we have no plans to remove the in-memory provider, we will not be adding any new features to this provider because we believe valuable development time is better spent in other areas. When feasible, we plan to still fix regressions in existing behavior.