Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider delaying the detection of modified key values to SaveChanges #19135

Open
Tracked by #22954
AndriySvyryd opened this issue Dec 2, 2019 · 1 comment
Open
Tracked by #22954

Consider delaying the detection of modified key values to SaveChanges #19135

AndriySvyryd opened this issue Dec 2, 2019 · 1 comment
Assignees
@AndriySvyryd
Labels
area-change-tracking area-save-changes consider-for-current-release punted-for-6.0 type-enhancement
Milestone
Backlog

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Dec 2, 2019 •
edited
Loading

This brings the handling of PropertySaveBehavior to one place, removes the need for the SavingChanges flag added in #19100 and is needed to allow reparenting of dependents with identifying FKs.
@AndriySvyryd AndriySvyryd mentioned this issue Dec 2, 2019
Merged
@ajcvickers ajcvickers added this to the Backlog milestone Dec 6, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Aug 30, 2020
Merged
@ajcvickers
Copy link
Member

When fixing this, the special check to prevent changing a key added in #22322 can be removed.

Also, consider doing this at the same time as #4073

@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 2, 2020
@ajcvickers ajcvickers self-assigned this Nov 2, 2020
This was referenced Nov 10, 2020
Closed
Merged
@ajcvickers ajcvickers removed their assignment May 6, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, Backlog Aug 12, 2021
AndriySvyryd added a commit that referenced this issue Aug 23, 2021
@AndriySvyryd
Move key modification detection logic to SaveChanges
76983a5 
Fixes #19135
@AndriySvyryd AndriySvyryd mentioned this issue Nov 19, 2021
Closed
@AndriySvyryd AndriySvyryd mentioned this issue Sep 9, 2022
Open
46 tasks
@ajcvickers ajcvickers self-assigned this Oct 21, 2022
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndriySvyryd AndriySvyryd

Labels
area-change-tracking area-save-changes consider-for-current-release punted-for-6.0 type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd