Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata: Disallow backing field on indexer property #19448

Closed
smitpatel opened this issue Dec 31, 2019 · 0 comments · Fixed by #19449
Closed

Metadata: Disallow backing field on indexer property #19448

smitpatel opened this issue Dec 31, 2019 · 0 comments · Fixed by #19449
Assignees
@smitpatel
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

Indexer properties defined as Property in metadata, allows setting a backing field of it.
We need to block it as per #13610 (comment)
@smitpatel smitpatel self-assigned this Jan 1, 2020
smitpatel added a commit that referenced this issue Jan 1, 2020
@smitpatel
Metadata: Disallow backing field on indexer property
ce6e1da 
- Don't discover backing field for indexer property by convention
- Throw if trying to set a backing field for indexer property

Resolves #19448
@smitpatel smitpatel mentioned this issue Jan 1, 2020
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 1, 2020
smitpatel added a commit that referenced this issue Jan 1, 2020
@smitpatel
Metadata: Disallow backing field on indexer property
2a216b8 
- Don't discover backing field for indexer property by convention
- Throw if trying to set a backing field for indexer property

Resolves #19448
smitpatel added a commit that referenced this issue Jan 1, 2020
@smitpatel
Metadata: Disallow backing field on indexer property
7d31196 
- Don't discover backing field for indexer property by convention
- Throw if trying to set a backing field for indexer property

Resolves #19448
smitpatel added a commit that referenced this issue Jan 1, 2020
@smitpatel
Metadata: Disallow backing field on indexer property
a8072e9 
- Don't discover backing field for indexer property by convention
- Throw if trying to set a backing field for indexer property

Resolves #19448
@smitpatel smitpatel reopened this Jan 1, 2020
smitpatel added a commit that referenced this issue Jan 1, 2020
@smitpatel
Metadata: Disallow backing field on indexer property
64b8b40 
- Don't discover backing field for indexer property by convention
- Throw if trying to set a backing field for indexer property

Resolves #19448
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jan 3, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Metadata: Disallow backing field on indexer property dotnet/efcore
2 participants
@ajcvickers @smitpatel