Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extra methods/properties in SpatialQueryTestBase #19957

Closed
EricStG opened this issue Feb 17, 2020 · 6 comments
Closed

Support extra methods/properties in SpatialQueryTestBase #19957

EricStG opened this issue Feb 17, 2020 · 6 comments
Labels
closed-no-further-action The issue is closed and no further action is planned. customer-reported
Milestone

Comments

@EricStG
Copy link
Contributor

EricStG commented Feb 17, 2020

I'm adding new translations to npgsql/efcore.pg#457 and noticed that support in SpatialQueryTestBase was missing for some of them, namely:

I'd like those methods and properties to be supported by the SpatialQueryTestBase class.

I can submit a PR if the project is open to those changes.

@ajcvickers
Copy link
Member

@EricStG Thanks, this would be great!

/cc @bricelam

@bricelam
Copy link
Contributor

👍 Adding them to SpatialQueryTestBase is the right thing to do since it'll force other providers to think about whether or not they can be translated.

One question: How are you handling the XmlReader of ToGMLFeature()? Only translating it if it's chained with ReadOuterXml()?

NTS MSSQL (geometry) MSSQL (geography) SpatiaLite
geometry.Normalized()
geometry.ToGMLFeature() geometry.AsGml() AsGml(geometry)
linearRing.IsCCW

@EricStG
Copy link
Contributor Author

EricStG commented Feb 19, 2020

I'll admit I didn't think this far into my process... I just happened to be starting with the other ones and noticed they were missing, but it seems to make sense to only translate it if it's chained with ReadOuterXml(0.

@bricelam
Copy link
Contributor

Another possibility: #19991

@ajcvickers ajcvickers added this to the Discussions milestone Feb 21, 2020
@ajcvickers
Copy link
Member

@EricStG We discussed this and concluded that maybe you should try just Normalized and IsCCW since these don't have the XmlReader complications.

@EricStG
Copy link
Contributor Author

EricStG commented Feb 21, 2020

@ajcvickers Works for me, thanks!

EricStG added a commit to EricStG/efcore that referenced this issue Feb 22, 2020
Added related stubs to Sqlite and SqlServer spatial tests
EricStG added a commit to EricStG/efcore that referenced this issue Feb 23, 2020
- Added related stubs to Sqlite and SqlServer spatial tests

Part of dotnet#19957
bricelam pushed a commit that referenced this issue Feb 24, 2020
- Added related stubs to Sqlite and SqlServer spatial tests

Part of #19957
@smitpatel smitpatel removed this from the Discussions milestone Mar 6, 2020
@ajcvickers ajcvickers added this to the Discussions milestone Mar 6, 2020
@ajcvickers ajcvickers added closed-no-further-action The issue is closed and no further action is planned. customer-reported labels Mar 6, 2020
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-no-further-action The issue is closed and no further action is planned. customer-reported
Projects
None yet
Development

No branches or pull requests

4 participants