Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use helix to get more coverage on SqlServer tests #19974

Closed
smitpatel opened this issue Feb 19, 2020 · 0 comments · Fixed by #23177
Closed

Use helix to get more coverage on SqlServer tests #19974

smitpatel opened this issue Feb 19, 2020 · 0 comments · Fixed by #23177
Assignees
@smitpatel
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@smitpatel
Copy link
Member

smitpatel commented Feb 19, 2020 •
edited
Loading

Windows image of helix would run it with localdb.
We can add testing for other OS (both of the below are untested)

  • Ubuntu we got it installed natively
    - OSX we got it through docker

We could also use developer edition to connect to actual server and run some of the functional tests which cannot be run on localdb.
@smitpatel smitpatel self-assigned this Feb 19, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Feb 21, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@smitpatel smitpatel added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed blocked labels Dec 14, 2020
@smitpatel smitpatel modified the milestones: MQ, 6.0.0 Dec 14, 2020
smitpatel added a commit that referenced this issue Dec 14, 2020
@smitpatel
Test SqlServer test on Ubuntu in helix
6013ae7 
Resolves #19974
Resolves #20128
@smitpatel smitpatel mentioned this issue Dec 14, 2020
Merged
smitpatel added a commit that referenced this issue Dec 14, 2020
@smitpatel
Test SqlServer test on Ubuntu in helix
77a6fbd 
Resolves #19974
Resolves #20128
@ghost ghost closed this as completed in #23177 Dec 15, 2020
ghost pushed a commit that referenced this issue Dec 15, 2020
@smitpatel
Test SqlServer test on Ubuntu in helix (#23177)
7582807 
Resolves #19974
Resolves #20128
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Test SqlServer test on Ubuntu in helix dotnet/efcore
2 participants
@ajcvickers @smitpatel