Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query/Sqlite: incorrect sql generated for int + string concat queries #19990

Closed
maumar opened this issue Feb 20, 2020 · 2 comments · Fixed by #20525
Closed

Query/Sqlite: incorrect sql generated for int + string concat queries #19990

maumar opened this issue Feb 20, 2020 · 2 comments · Fixed by #20525
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Feb 20, 2020

SqliteQuerySqlGenerator -> GenerateOperator is supposed to generate string concat operator || for Add operator and when type is string. However for case when int is concatenated with string, the type is object
@smitpatel
Copy link
Member

smitpatel commented Feb 20, 2020 •
edited
Loading

Why the type is object in SqlBinaryExpression?

@maumar maumar mentioned this issue Feb 20, 2020
Merged
@smitpatel
Copy link
Member

Notes:

  • SqlExpression.Type object should not be present in the tree for most cases except un-configured SqlConvert.
  • To infer type of Binary, don't use just left.Type
  • To infer type of Unary, be smart.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Feb 21, 2020
@bricelam bricelam removed their assignment Feb 21, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 3, 2020
smitpatel added a commit that referenced this issue Apr 3, 2020
@smitpatel
Query: Assign types for SqlExpression correctly
402dce1 
Resolves #19990
When inferring type mapping, use inferred type mapping's clr type to determine resulting sqlExpression's type.
smitpatel added a commit that referenced this issue Apr 3, 2020
@smitpatel
Query: Assign types for SqlExpression correctly
ae06158 
Resolves #19990
When inferring type mapping, use inferred type mapping's clr type to determine resulting sqlExpression's type.
smitpatel added a commit that referenced this issue Apr 3, 2020
@smitpatel
Query: Assign types for SqlExpression correctly
818497d 
Resolves #19990
When inferring type mapping, use inferred type mapping's clr type to determine resulting sqlExpression's type.
@smitpatel smitpatel mentioned this issue Apr 3, 2020
Merged
smitpatel added a commit that referenced this issue Apr 4, 2020
@smitpatel
Query: Assign types for SqlExpression correctly
e162edf 
Resolves #19990
When inferring type mapping, use inferred type mapping's clr type to determine resulting sqlExpression's type.
smitpatel added a commit that referenced this issue Apr 6, 2020
@smitpatel
Query: Assign types for SqlExpression correctly
8f764c9 
Resolves #19990
When inferring type mapping, use inferred type mapping's clr type to determine resulting sqlExpression's type.
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@smitpatel smitpatel mentioned this issue May 5, 2020
Closed
@roji roji mentioned this issue Jun 3, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Assign types for SqlExpression correctly dotnet/efcore
4 participants
@bricelam @ajcvickers @smitpatel @maumar