Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: improve logic around Contains(byte array) #20155

Closed
maumar opened this issue Mar 4, 2020 · 2 comments · Fixed by #20489
Closed

Query: improve logic around Contains(byte array) #20155

maumar opened this issue Mar 4, 2020 · 2 comments · Fixed by #20489
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Mar 4, 2020

Currently we special case how he handle contains on byte arrays. This should be cleaned up - AllAnyContainsRewritingExpressionVisitor should be able to run after nav expansion, but currently some cases of entity equality require it to run before it.
@maumar maumar mentioned this issue Mar 4, 2020
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 6, 2020
@smitpatel
Copy link
Member

Depends on #20164

@smitpatel smitpatel mentioned this issue Mar 21, 2020
Closed
@roji
Copy link
Member

roji commented Mar 22, 2020

Just to keep in mind... In PostgreSQL byte[] can be mapped in two ways: either as a binary type (called bytea, this is the default mapping), or as an array of bytes (just like you can have arrays of ints, arrays of strings). Being able to map to array of bytes is actually important to some users - sometimes used for enums with underlying byte type. Tell me if you need/want more details.

@smitpatel smitpatel mentioned this issue Mar 28, 2020
Closed
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 1, 2020
smitpatel added a commit that referenced this issue Apr 1, 2020
@smitpatel
Query: Merge query optimizing expression visitors
8b6bba7 
Part of #18923

Resolves #20155
Resolves #20369
We convert Queryable.Contains to Queryable.Any after navigation expansion has run so only true queraybles would have Queryable.Contains. Array properties would have Enumerable.Contains hence does not get rewritten.

Resolves #19433
smitpatel added a commit that referenced this issue Apr 1, 2020
@smitpatel
Query: Merge query optimizing expression visitors
e0273fc 
Part of #18923

Resolves #20155
Resolves #20369
We convert Queryable.Contains to Queryable.Any after navigation expansion has run so only true queraybles would have Queryable.Contains. Array properties would have Enumerable.Contains hence does not get rewritten.

Resolves #19433
@smitpatel smitpatel mentioned this issue Apr 1, 2020
Merged
smitpatel added a commit that referenced this issue Apr 1, 2020
@smitpatel
Query: Merge query optimizing expression visitors
0f28f71 
Part of #18923

Resolves #20155
Resolves #20369
We convert Queryable.Contains to Queryable.Any after navigation expansion has run so only true queraybles would have Queryable.Contains. Array properties would have Enumerable.Contains hence does not get rewritten.

Resolves #19433
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Merge query optimizing expression visitors dotnet/efcore
4 participants
@ajcvickers @smitpatel @maumar @roji