Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Features which can be detected should not be overridden from env vars #20274

Closed
smitpatel opened this issue Mar 13, 2020 · 0 comments · Fixed by #20313
Closed

Test: Features which can be detected should not be overridden from env vars #20274

smitpatel opened this issue Mar 13, 2020 · 0 comments · Fixed by #20313
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

FullTextSearch. We detect by querying database and we also have env variable to configure it too. We should remove env var and run the test if server supports it. We do that kind of detection for localdb/SqlAzure already.
@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 16, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 17, 2020
@smitpatel smitpatel linked a pull request Mar 18, 2020 that will close this issue
Clean up in SqlServer functional tests config #20313
Merged
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview3 Mar 31, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview3, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Clean up in SqlServer functional tests config dotnet/efcore
2 participants
@ajcvickers @smitpatel