Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up in SqlServer functional tests config #20313

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Clean up in SqlServer functional tests config #20313

merged 1 commit into from
Mar 17, 2020

Conversation

smitpatel
Copy link
Member

  • Remove TeamCity CI condition
  • Remove SupportsOffset as our lowest supported SqlServer version supports offset
  • Remove env variable for FreeText and detect by connecting to server

@smitpatel
Clean up in SqlServer functional tests config
0b06cd7 
- Remove TeamCity CI condition
- Remove SupportsOffset as our lowest supported SqlServer version supports offset
- Remove env variable for FreeText and detect by connecting to server
@smitpatel smitpatel requested a review from a team March 17, 2020 14:02
bricelam
bricelam approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we detect sequences, memory-optimized, hidden columns, and online index creation?

@smitpatel
Copy link
Member Author

Filed #20318

@smitpatel smitpatel merged commit 0573af8 into master Mar 17, 2020
@smitpatel smitpatel deleted the smit/envvars branch March 17, 2020 17:56
@AndriySvyryd
Copy link
Member

Last time I checked there was no reliable way of detecting memory-optimized that didn't involve catching exceptions

@smitpatel smitpatel linked an issue Mar 18, 2020 that may be closed by this pull request
Test: Features which can be detected should not be overridden from env vars #20274
Closed
@ajcvickers ajcvickers mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test: Features which can be detected should not be overridden from env vars
3 participants
@smitpatel @AndriySvyryd @bricelam