Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect SqlServer features automagically rather than using env vars #20318

Closed
smitpatel opened this issue Mar 17, 2020 · 4 comments · Fixed by #20371
Closed

Detect SqlServer features automagically rather than using env vars #20318

smitpatel opened this issue Mar 17, 2020 · 4 comments · Fixed by #20371
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

@bricelam wrote
Can we detect sequences, memory-optimized, hidden columns, and online index creation?
@smitpatel smitpatel mentioned this issue Mar 17, 2020
Merged
@ErikEJ
Copy link
Contributor

ErikEJ commented Mar 17, 2020

Assuming you only support SQL Server 2012 or later, sequences are always supported.

Memory optimized: https://github.com/dotnet/efcore/blob/master/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs#L1111

Hidden columns: https://github.com/dotnet/efcore/blob/master/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs#L1106

Online index creation: EngineEdition IN (3,5,8)

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Mar 18, 2020 •
edited
Loading

@ErikEJ That only indicates whether the server supports the syntax, the in-memory feature also needs to be installed among other requirements to be able to succesfully create an in-memory table.

@ajcvickers
Copy link
Member

@ErikEJ Consider making a PR?

@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 20, 2020
@ajcvickers ajcvickers removed this from the 5.0.0 milestone Mar 20, 2020
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Mar 20, 2020
ErikEJ added a commit to ErikEJ/EntityFramework that referenced this issue Mar 22, 2020
@ErikEJ
Detect SqlServer features automagically rather than using env vars
48674c6 
fixes dotnet#20318

I have attempted to cater for current implicit assumptions - but it is opaque to me what SQL Server edtions tests are actually run against.

Tested with SQL 2016 Developer Edition and LocalDb version 14
@ErikEJ ErikEJ mentioned this issue Mar 22, 2020
Merged
@ErikEJ
Copy link
Contributor

ErikEJ commented Mar 22, 2020

Yes! PR submitted.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 23, 2020
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 24, 2020
ErikEJ added a commit to ErikEJ/EntityFramework that referenced this issue Mar 25, 2020
@ErikEJ
Detect SqlServer features automagically rather than using env vars
766507b 
fixes dotnet#20318

I have attempted to cater for current implicit assumptions - but it is opaque to me what SQL Server edtions tests are actually run against.

Tested with SQL 2016 Developer Edition and LocalDb version 14
ajcvickers pushed a commit that referenced this issue Mar 26, 2020
@ErikEJ
Detect SqlServer features automagically rather than using env vars (#…
abcedd6 
…20371)

fixes #20318

I have attempted to cater for current implicit assumptions - but it is opaque to me what SQL Server edtions tests are actually run against.

Tested with SQL 2016 Developer Edition and LocalDb version 14
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview3 Mar 31, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview3, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Detect SqlServer features automagically rather than using env vars ErikEJ/EntityFramework
4 participants
@ajcvickers @smitpatel @ErikEJ @AndriySvyryd