Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparers are internal #20387

Closed
5 tasks done
smitpatel opened this issue Mar 23, 2020 · 2 comments · Fixed by #20538
Closed
5 tasks done

Comparers are internal #20387

smitpatel opened this issue Mar 23, 2020 · 2 comments · Fixed by #20538
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

smitpatel commented Mar 23, 2020 •
edited by ajcvickers
Loading

  • ForeignKeyComparer
  • EntityTypePathComparer
  • IndexComparer
  • KeyComparer
  • ReferenceEqualityComparer
@ajcvickers ajcvickers self-assigned this Mar 27, 2020
@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 27, 2020
@ajcvickers
Copy link
Member

@AndriySvyryd I've been looking through these and think we could make them all public. If anyone needs to compare metadata items, then I'd rather they use ours than roll their own. Okay with that?

@AndriySvyryd
Copy link
Member

Perhaps if we name/document them properly. My concern is that without looking the implementation one may assume that they check for equality, however they only compare identity.

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 5, 2020
ajcvickers added a commit that referenced this issue Apr 5, 2020
@ajcvickers
Make a selection of comparers public
fd33e46 
Fixes #20387
@ajcvickers ajcvickers mentioned this issue Apr 5, 2020
Merged
ajcvickers added a commit that referenced this issue Apr 7, 2020
@ajcvickers
Make a selection of comparers public
291f8fb 
Fixes #20387
ajcvickers added a commit that referenced this issue Apr 7, 2020
@ajcvickers
Make a selection of comparers public
eff380c 
Fixes #20387
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Make a selection of comparers public dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd