Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making AnonymousObject public #20565

Closed
ajcvickers opened this issue Apr 7, 2020 · 4 comments · Fixed by #20644
Closed

Consider making AnonymousObject public #20565

ajcvickers opened this issue Apr 7, 2020 · 4 comments · Fixed by #20644
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Member

In-memory provider uses it.
@smitpatel
Copy link
Member

Even relational does. typeof(AnonymousOjbect) is not caught in analyzers.

@smitpatel
Copy link
Member

Though I would recommend on the side of not making it public. It has potential of being misused.

@ajcvickers
Copy link
Member Author

@roji typeof() seems to be another case of #20206.

@roji
Copy link
Member

roji commented Apr 10, 2020

@ajcvickers added this to #20206, thanks.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Apr 13, 2020
smitpatel added a commit that referenced this issue Apr 15, 2020
@smitpatel
Query: Remove AnonymousObject
c3081de 
- Make it implementation detail of InMemory provider which still needs it to match outer/inner keys of a join executed on server side

Resolves #20565
@smitpatel smitpatel mentioned this issue Apr 15, 2020
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 15, 2020
smitpatel added a commit that referenced this issue Apr 16, 2020
@smitpatel
Query: Remove AnonymousObject
58a07b6 
- Make it implementation detail of InMemory provider which still needs it to match outer/inner keys of a join executed on server side

Resolves #20565
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Remove AnonymousObject dotnet/efcore
3 participants
@ajcvickers @smitpatel @roji