Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Cosmos DB Connection strings #20712

Closed
bradygaster opened this issue Apr 21, 2020 · 1 comment · Fixed by #21088
Closed

Add support for Cosmos DB Connection strings #20712

bradygaster opened this issue Apr 21, 2020 · 1 comment · Fixed by #21088
Labels
area-cosmos closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone
5.0.0

Comments

@bradygaster
Copy link
Member

Current State
Currently, the DbContextOptionsBuilder.UseCosmos method has one overload that takes the Cosmos DB URI and key.

Potential Issue
We're about to ship some updates in the tooling that will dial in the Cosmos DB connection string more elegantly. Customers who use that tooling would get a connection string handed to them in config, but they'd have a paper cut here - they can't use that pre-wired-up connection string with the UseCosmos method.

Proposed Solution
Add an overload that takes a single string rather than the URI and the key, and take in the Connection String the tooling team will be pulling down from the Cosmos DB RP.

Adding @timheuer and @AngelosP and @vijayrkn FYI for visibility. If you'd like support on the feature let us know.
@ajcvickers ajcvickers added this to the 5.0.0 milestone Apr 24, 2020
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Apr 24, 2020
@Marusyk
Copy link
Member

Marusyk commented May 30, 2020

I need this overload. I'll prepare PR for this

@Marusyk Marusyk mentioned this issue May 30, 2020
Merged
Marusyk added a commit to Marusyk/efcore that referenced this issue Jun 14, 2020
@Marusyk
Add an overload to UseCosmos that takes a connection string (dotnet#2…
c2b4cc7 
…0712)
AndriySvyryd pushed a commit that referenced this issue Jun 14, 2020
@Marusyk
Add an overload to UseCosmos that takes a connection string
d724d08 
Fixes #20712
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 14, 2020
@AndriySvyryd AndriySvyryd removed their assignment Jun 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview7 Jun 22, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview7, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add an overload to UseCosmos that takes a connection string Marusyk/efcore
4 participants
@ajcvickers @AndriySvyryd @Marusyk @bradygaster