Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enum constraints convention out of EF Core to a plugin #20897

Closed
roji opened this issue May 9, 2020 · 3 comments
Closed

Move enum constraints convention out of EF Core to a plugin #20897

roji opened this issue May 9, 2020 · 3 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone

Comments

@roji
Copy link
Member

roji commented May 9, 2020

#15411 added a convention to create database check constraints for enums. We've decided this would be more appropriate for an external plugin for the following reasons:

  • Check constraints have a perf impact, and if the database is only accessed by EF they aren't needed. A plugin would provide an explicit opt-in for this.
  • The current convention is SQL Server-specific, but could be used on other databases as well (Move enum check constraints convention to relational? #20878).
@roji
Copy link
Member Author

roji commented May 9, 2020

PR for the plugin: efcore/EFCore.CheckConstraints#1

roji added a commit that referenced this issue May 9, 2020
As part of moving it out to a plugin

Part of #20897
roji added a commit that referenced this issue May 9, 2020
As part of moving it out to a plugin

Part of #20897
@smitpatel
Copy link
Member

@roji - I think you already completed this work item.

@roji
Copy link
Member Author

roji commented May 21, 2020

Thanks @smitpatel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Development

No branches or pull requests

3 participants