Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: ColumnMappings to use for TVF/FromSql #21511

Closed
smitpatel opened this issue Jul 3, 2020 · 1 comment · Fixed by #21722
Closed

Query: ColumnMappings to use for TVF/FromSql #21511

smitpatel opened this issue Jul 3, 2020 · 1 comment · Fixed by #21722
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

SelectExpression has a ctor (also associated public method in SqlExpressionFactory) which takes the TableExpressionBase which acts as the source of the data. This is used for scenarios like TVF/FromSql (which currently works with TPH or non-hierarchy only).
We need to determine which column mappings to use when generating columns from database, since this code path is encountered while not using any particular entity type mapping from model.
@smitpatel smitpatel self-assigned this Jul 3, 2020
@smitpatel smitpatel mentioned this issue Jul 3, 2020
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jul 6, 2020
@smitpatel
Copy link
Member Author

Blocked on #13358 for FromSql part.

@smitpatel smitpatel removed the blocked label Jul 21, 2020
smitpatel added a commit that referenced this issue Jul 21, 2020
@smitpatel
Query: Use correct column mappings for TVF/FromSql
391acc0 
Resolves #21511
@smitpatel smitpatel mentioned this issue Jul 21, 2020
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 21, 2020
smitpatel added a commit that referenced this issue Jul 21, 2020
@smitpatel
Query: Use correct column mappings for TVF/FromSql
aa6cfb7 
Resolves #21511
smitpatel added a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Use correct column mappings for TVF/FromSql
17b29b2 
Resolves #21511
smitpatel added a commit that referenced this issue Jul 22, 2020
@smitpatel
Query: Use correct column mappings for TVF/FromSql (#21722)
d0ec185 
Resolves #21511
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Use correct column mappings for TVF/FromSql dotnet/efcore
2 participants
@ajcvickers @smitpatel