Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Default Join Entity Type Property Names #21567

Closed
lajones opened this issue Jul 8, 2020 · 3 comments · Fixed by #21811
Closed

Update Default Join Entity Type Property Names #21567

lajones opened this issue Jul 8, 2020 · 3 comments · Fixed by #21811
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@lajones
Copy link
Contributor

lajones commented Jul 8, 2020

At the moment, when we create properties to hold the FKs involved in an implicit many-to-many join entity, we define the names of those properties from "{ETSN}_{propName}" where {ETSN} = declaringEntityType.ShortName(), {propName} = the property's name on declaringEntityType, where declaringEntityType is in turn both of the two outer entities in the join and the properties are from that entity type's PK.

At the Design Meeting on July 8 we decided to update this to name the foreign properties whatever we use elsewhere in the code when creating FKs "behind the scenes".

@lajones lajones self-assigned this Jul 8, 2020
@smitpatel
Copy link
Member

If you just create the FK, then it will create appropriate FK properties automatically. So there is no need for M2M to even worry about property names. I think the convention to set PK for association entity for create FK values is tracked elsewhere.

@lajones
Copy link
Contributor Author

lajones commented Jul 8, 2020

@smitpatel Yes. But it doesn't do that at present - so I need to update the code. This is to keep track of that.

@AndriySvyryd
Copy link
Member

Poaching

AndriySvyryd added a commit that referenced this issue Jul 27, 2020
Remove implicit join entity type in a convention
Configure PK for join entity type in a convention
Consolidate HasNoSkipNavigation usage

Fixes #21567
AndriySvyryd added a commit that referenced this issue Jul 27, 2020
Remove implicit join entity type in a convention
Configure PK for join entity type in a convention
Consolidate HasNoSkipNavigation usage

Fixes #21567
@ghost ghost closed this as completed in #21811 Jul 28, 2020
ghost pushed a commit that referenced this issue Jul 28, 2020
Remove implicit join entity type in a convention
Configure PK for join entity type in a convention
Consolidate HasNoSkipNavigation usage

Fixes #21567
@AndriySvyryd AndriySvyryd removed their assignment Jul 28, 2020
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 28, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants