Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: Generate more code using IAnnotationCodeGenerator #21882

Closed
bricelam opened this issue Jul 31, 2020 · 0 comments · Fixed by #28358
Closed

Design: Generate more code using IAnnotationCodeGenerator #21882

bricelam opened this issue Jul 31, 2020 · 0 comments · Fixed by #28358
Assignees
@bricelam @roji
Labels
area-migrations area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
7.0.0

Comments

@bricelam
Copy link
Contributor

We did some refactoring in PR #21329 to unify how model configuration code was generated in scaffolding and migrations. We should continue that work and move more code to use IAnnotationCodeGenerator.
@ajcvickers ajcvickers added this to the Backlog milestone Aug 3, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
bricelam added a commit to bricelam/efcore that referenced this issue Jul 1, 2022
@bricelam
Scaffolding: Refactor some code
8895fe1 
Part of dotnet#4038, part of dotnet#27588, fixes dotnet#27598, resolves dotnet#8434, resolves dotnet#21882, fixes dotnet#26349
@bricelam bricelam mentioned this issue Jul 1, 2022
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 1, 2022
@bricelam bricelam modified the milestones: MQ, 7.0.0 Jul 1, 2022
@bricelam bricelam modified the milestones: 7.0.0, 7.0.0-preview7 Jul 11, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview7, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

@roji roji

Labels
area-migrations area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Scaffolding: Refactor some code bricelam/efcore
3 participants
@bricelam @ajcvickers @roji