Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Resources.tt to sort the .resx file #22156

Closed
bricelam opened this issue Aug 20, 2020 · 1 comment · Fixed by #22171
Closed

Update Resources.tt to sort the .resx file #22156

bricelam opened this issue Aug 20, 2020 · 1 comment · Fixed by #22171
Assignees
@bricelam
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Aug 20, 2020 •
edited
Loading

Most of my merge conflicts these days are caused by added resource strings. We should update the .tt file to sort the .resx file when it generates the .cs file. I have a gist that does that; I used to use it on my ImageResizer project to merge in updated translations.
@bricelam bricelam self-assigned this Aug 20, 2020
@bricelam bricelam mentioned this issue Aug 20, 2020
Merged
@ajcvickers
Copy link
Member

I use the random insertion approach: put the new string at some random location in the file, not the beginning or end, and preferably somewhere with related strings. 🙃

But this is better.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Aug 21, 2020
bricelam added a commit to bricelam/efcore that referenced this issue Aug 21, 2020
@bricelam
Sort resx file on generate
c59ed17 
Fixes dotnet#22156
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 21, 2020
@bricelam bricelam modified the milestones: 5.0.0, 5.0.0-rc1 Aug 21, 2020
@bricelam bricelam mentioned this issue Aug 21, 2020
Merged
@ghost ghost closed this as completed in #22171 Aug 22, 2020
ghost pushed a commit that referenced this issue Aug 22, 2020
@bricelam
Sort resx file on generate (#22171)
dd3fc4f 
Fixes #22156
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Sort resx file on generate bricelam/efcore
2 participants
@bricelam @ajcvickers