Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache SkipDetectChanges on model as a field #22262

Closed
smitpatel opened this issue Aug 27, 2020 · 0 comments · Fixed by #22281
Closed

Cache SkipDetectChanges on model as a field #22262

smitpatel opened this issue Aug 27, 2020 · 0 comments · Fixed by #22281
Assignees
@smitpatel
Labels
area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

@AndriySvyryd wrote

Caching Model[CoreAnnotationNames.SkipDetectChangesAnnotation] in other places should also give good results, this should probably be moved to a field on Model instead of an annotation
@smitpatel smitpatel self-assigned this Aug 27, 2020
@smitpatel smitpatel mentioned this issue Aug 27, 2020
Merged
@smitpatel smitpatel added this to the 5.0.0 milestone Aug 27, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 27, 2020
@smitpatel smitpatel modified the milestones: 5.0.0, 5.0.0-rc1 Aug 27, 2020
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache SkipDetectChanges on model as a field
2e69c34 
Resolves #22262
@smitpatel smitpatel mentioned this issue Aug 27, 2020
Merged
smitpatel added a commit that referenced this issue Aug 27, 2020
@smitpatel
Perf: Cache SkipDetectChanges on model as a field
56c5309 
Resolves #22262
smitpatel added a commit that referenced this issue Aug 28, 2020
@smitpatel
Perf: Cache SkipDetectChanges on model as a field (#22281)
3847feb 
Resolves #22262
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Perf: Cache SkipDetectChanges on model as a field dotnet/efcore
2 participants
@ajcvickers @smitpatel