Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf regression in change-tracking #22503

Closed
ajcvickers opened this issue Sep 11, 2020 · 1 comment
Closed

Perf regression in change-tracking #22503

ajcvickers opened this issue Sep 11, 2020 · 1 comment
Labels
area-change-tracking area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression Servicing-approved type-bug
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Member

image
@ajcvickers ajcvickers added this to the 5.0.0-rc2 milestone Sep 11, 2020
@ajcvickers
Copy link
Member Author

Did a bit of investigation into this; looks like unannotationization of CoreAnnotationNames.ChangeTrackingStrategy will help significantly.

AndriySvyryd added a commit that referenced this issue Sep 14, 2020
@AndriySvyryd
Change ChangeTrackingStrategy from annotation to field
465f7ba 
Fixes #22503
@AndriySvyryd AndriySvyryd mentioned this issue Sep 14, 2020
Merged
AndriySvyryd added a commit that referenced this issue Sep 14, 2020
@AndriySvyryd
Change ChangeTrackingStrategy from annotation to field
9387ef9 
Fixes #22503
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 14, 2020
@AndriySvyryd AndriySvyryd removed their assignment Sep 21, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc2, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-change-tracking area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression Servicing-approved type-bug
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @AndriySvyryd