NavigationFixer.SetForeignKeyProperties doesn't set value as StoreGenerated

[AndriySvyryd]

It means that when inserting a principal entity with a store-generated key and a dependent in the same transaction and something fails after the principal was inserted the dependent might end up disconnected as it will retain the store-generated FK value that is no longer valid.

[ajcvickers]

@AndriySvyryd Is this something you think we should fix for 5.0?

[AndriySvyryd]

No, I don't think this is a regression.

[stevendarby]

@ajcvickers Cool, I think I spotted this recently doing some work on resiliency when saving changes. The example given above mentions an error occurring between inserts- can I just check that this also covers the case where saving succeeds but changes have not been accepted yet? Currently the dependent FK is set at this point even though the principal ID isn’t. Looking at the PR I am fairly sure it fixes this too but I wanted to check in case it’s a separate issue worth raising. Thanks!

[ajcvickers]

@stevendarby Yes, that is the same issue. Should now be fixed so that the FK is set at the same time as the PK. It would be good to give it a try to make sure, or maybe even submit a test for it.