Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable reference nullability in migrations and model snapshot #25624

Closed
roji opened this issue Aug 20, 2021 · 0 comments · Fixed by #25626 or #25629
Closed

Disable reference nullability in migrations and model snapshot #25624

roji opened this issue Aug 20, 2021 · 0 comments · Fixed by #25626 or #25629
Assignees
@roji
Labels
area-migrations closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Aug 20, 2021

Our generated migrations and model snapshot don't contain NRT code, so in some scenarios they don't compile if nullability has been enabled at the project level. Add #nullable disable in generated files to temporarily work around this issue. #18950 tracks generating proper NRT code in the future.
@roji roji added this to the 6.0.0 milestone Aug 20, 2021
@roji roji self-assigned this Aug 20, 2021
@roji roji mentioned this issue Aug 20, 2021
Open
roji added a commit that referenced this issue Aug 20, 2021
@roji
Disable nullability in migrations
9e2600f 
Closes #25624
@roji roji mentioned this issue Aug 20, 2021
Merged
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 20, 2021
roji added a commit that referenced this issue Aug 20, 2021
@roji
Disable nullability in migrations (#25626)
97247ec 
Closes #25624
roji added a commit that referenced this issue Aug 20, 2021
@roji
Disable nullability in migrations (#25626)
89828dd 
Closes #25624
@roji roji mentioned this issue Aug 20, 2021
Merged
@roji roji linked a pull request Aug 20, 2021 that will close this issue
Disable nullability in migrations (RC1) #25629
Merged
ghost pushed a commit that referenced this issue Aug 20, 2021
@roji
Disable nullability in migrations (#25626) (#25629)
247a2cf 
Closes #25624
@roji roji mentioned this issue Aug 20, 2021
Merged
AndriySvyryd pushed a commit that referenced this issue Aug 20, 2021
@roji
Disable nullability in migrations
b30d841 
Closes #25624
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc2 Aug 26, 2021
@maumar maumar mentioned this issue Sep 7, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc2, 6.0.0 Nov 8, 2021
@cvium cvium mentioned this issue Oct 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-migrations closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Milestone
6.0.0
2 participants
@ajcvickers @roji