Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidateBoolsWithDefaults should take bool? backing fields into account #28509

Closed
NinoFloris opened this issue Jul 25, 2022 · 0 comments · Fixed by #30395
Closed

ValidateBoolsWithDefaults should take bool? backing fields into account #28509

NinoFloris opened this issue Jul 25, 2022 · 0 comments · Fixed by #30395
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone
8.0.0

Comments

@NinoFloris
Copy link

Given the following pattern is supported since 3.1? #15182

https://github.com/dotnet/efcore/blame/037fc6fd2b9ac099b8b305dccc355d61846b6032/src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs#L215
The validation here should take into account whether a bool? backing field for the property exists. This would be valid as long as a field with that type is known and the property access mode is suitable.

Doing so would align the validation with the supported pattern.
@ajcvickers ajcvickers added this to the Backlog milestone Jul 28, 2022
@ajcvickers ajcvickers self-assigned this Jul 28, 2022
ajcvickers added a commit that referenced this issue Mar 3, 2023
@ajcvickers
Don't warn in model validation when bool property with default value …
ddc76c9 
…has nullable backing field

Fixes #28509
@ajcvickers ajcvickers modified the milestones: Backlog, 8.0.0 Mar 3, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 3, 2023
@ajcvickers ajcvickers mentioned this issue Mar 3, 2023
Merged
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview3 Mar 13, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview3, 8.0.0 Nov 14, 2023
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Milestone
8.0.0
2 participants
@ajcvickers @NinoFloris