Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the new LINQ Order/OrderDescending #28634

Closed
Tracked by #25570
roji opened this issue Aug 9, 2022 · 6 comments · Fixed by #34282
Closed
Tracked by #25570

Translate the new LINQ Order/OrderDescending #28634

roji opened this issue Aug 9, 2022 · 6 comments · Fixed by #34282
Assignees
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@roji
Copy link
Member

roji commented Aug 9, 2022

See blog post.

These new methods aren't useful over entities, but can be useful after the user has projected from the entity to some column and wants to order that. Should be pretty trivial.

@smitpatel
Copy link
Member

I wonder if we should just convert to OrderBy(e => e) in pre-translation phase.

@roji
Copy link
Member Author

roji commented Aug 9, 2022

Yep, that seems easiest...

@smitpatel
Copy link
Member

May be we should let users do that through interceptors. :trollface:

@roji
Copy link
Member Author

roji commented Aug 9, 2022

That would certainly be the workaround until we do this 🤣

@smitpatel
Copy link
Member

This API is in .NET 7 only and we are still on net6.0 tfm

@smitpatel smitpatel removed this from the 8.0.0 milestone Nov 9, 2022
@smitpatel smitpatel removed their assignment Nov 9, 2022
@ajcvickers ajcvickers added this to the Backlog milestone Nov 16, 2022
@roji
Copy link
Member Author

roji commented Dec 6, 2022

Note: we already support OrderBy(x => x) on entity types (orders by the primary key), so it should be OK to do the same with the above.

bricelam added a commit to bricelam/efcore that referenced this issue Jul 24, 2024
roji pushed a commit to bricelam/efcore that referenced this issue Aug 13, 2024
@roji roji closed this as completed in 6e71839 Aug 13, 2024
@roji roji modified the milestones: Backlog, 9.0.0 Aug 13, 2024
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 13, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-rc1 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants