Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Detect primary key property renames #6404

Closed
bricelam opened this issue Aug 24, 2016 · 4 comments
Closed

Migrations: Detect primary key property renames #6404

bricelam opened this issue Aug 24, 2016 · 4 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement

Comments

@bricelam
Copy link
Contributor

Similar to #5155 (but perhaps not as useful), we could also detect renamed properties that are part of the primary key if...

  1. The number of primary key properties are the same, and
  2. The would-be-added property is in the same position as a would-be-removed property
@bricelam
Copy link
Contributor Author

I need to think about it more, but my initial feeling is that it becomes even less useful for alternate keys, and indices.

@bricelam
Copy link
Contributor Author

Also, I wonder if just doing structural matching (e.g. everything is the same except the name) would cover all these cases for much cheaper.

@divega divega added this to the 1.1.0 milestone Aug 25, 2016
@divega divega removed this from the 1.1.0 milestone Aug 25, 2016
@divega divega assigned bricelam and unassigned rowanmiller Aug 25, 2016
@divega divega added this to the 1.1.0 milestone Aug 25, 2016
@divega
Copy link
Contributor

divega commented Aug 25, 2016

Triage: we want to have a design discussion about this, including @rowanmiller.

@bricelam bricelam removed the blocked label Sep 12, 2016
@bricelam bricelam removed this from the 1.1.0 milestone Sep 12, 2016
@rowanmiller rowanmiller added this to the 1.1.0 milestone Sep 13, 2016
@bricelam
Copy link
Contributor Author

Closing in favor of doing #6582 instead.

@bricelam bricelam added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Sep 21, 2016
@bricelam bricelam removed this from the 1.1.0 milestone Sep 21, 2016
@bricelam bricelam removed their assignment Sep 21, 2016
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants