Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Detect renamed properties #6582

Closed
bricelam opened this issue Sep 21, 2016 · 0 comments
Closed

Migrations: Detect renamed properties #6582

bricelam opened this issue Sep 21, 2016 · 0 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Sep 21, 2016

We currently detect renaming a column, but detecting renamed properties is harder because they could easily be intended for adding and removing a column.

We could go down the path of using contextual information like #5155 & #6404 propose, but that seems a little excessive. We could also mimic EF6 where if 80% of the metadata is the same, we consider it a rename, but this yielded false positives.

I propose we consider a column renamed if only the name is different. This will catch the same cases as the two referenced issues, and hopefully yield less false positives.

@bricelam bricelam added this to the 1.1.0 milestone Sep 21, 2016
@bricelam bricelam self-assigned this Sep 21, 2016
@bricelam bricelam changed the title Migrations: Detected renamed properties Migrations: Detect renamed properties Sep 21, 2016
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 5, 2016
@ajcvickers ajcvickers modified the milestones: 1.1.0-preview1, 1.1.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants