Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ConventionScope #19297

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Refactor ConventionScope #19297

merged 2 commits into from
Dec 17, 2019

Conversation

AndriySvyryd
Copy link
Member

No description provided.

@AndriySvyryd AndriySvyryd force-pushed the ConventionNodeRefactor branch 2 times, most recently from 059adbb to 01433e2 Compare December 13, 2019 17:21
smitpatel
smitpatel approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AndriySvyryd AndriySvyryd merged commit 16a6c3c into master Dec 17, 2019
@AndriySvyryd AndriySvyryd deleted the ConventionNodeRefactor branch December 17, 2019 18:59
@ajcvickers ajcvickers mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriySvyryd @smitpatel