Even more controversial: Allow creation of a DbCommand from an EF IQueryable #19335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides access to all the real parameter values, including facets. Should be executable. However, pretty sure people will think this isn't a good idea...
ajcvickers
requested review from
smitpatel,
roji,
maumar,
AndriySvyryd and
bricelam
|
This would be an alternative to #19334 rather than an addition, right? I still don't find this very controversial :) A DbCommand can be seen as a tuple of SQL and parameters, which also happens to be directly executable. I like it. API-wise it's also a bit cleaner than #19334, where the parameters is an "out" parameter. BTW it's good that this is restricted to relational - we should consider doing this regardless of whether we implement DbCommand or leave just query string. |
|
Apologies, I meant to write above that I don't find this very controversial, but ended up writing the opposite. |
|
@AndriySvyryd @smitpatel @roji @bricelam @maumar I think we agreed in the design meeting that we were going to to this. Can I get an approval? |
smitpatel
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides access to all the real parameter values, including facets. Should be executable.
However, pretty sure people will think this isn't a good idea...