Query: Lift pending collections property when applying single result … #19345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…projection Resolves #18812 Issue: When generating left join for single result using RowNumber, pending collection from inner was bubbling up but we lost it when generating join. Later when we encountered CollectionShaperExpression, we threw exception since projectionBindingExpression there references collectionId rather than actual projection Fix: Copy over pending collection for join. Remap collection shapers if any.
maumar
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…projection
Resolves #18812
Issue: When generating left join for single result using RowNumber, pending collection from inner was bubbling up but we lost it when generating join.
Later when we encountered CollectionShaperExpression, we threw exception since projectionBindingExpression there references collectionId rather than actual projection
Fix: Copy over pending collection for join. Remap collection shapers if any.