Allow DbConnection or connection string to be changed on existing DbContext #19376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
roji,
smitpatel,
AndriySvyryd,
maumar and
bricelam
and removed request for
roji
|
Some of the scenarios where this is useful are dynamic load balancing and failover and the obvious place to change the connection string for those is in an interceptor. Could you add command, connection and transaction interceptor tests that change the connection string? |
smitpatel
reviewed
Dec 21, 2019
ajcvickers
force-pushed
the
ThreeBallsOneHat1220
branch
from
71629ea
to
0e31df4
Compare
|
@AndriySvyryd Updated, including additional tests. |
ajcvickers
force-pushed
the
ThreeBallsOneHat1220
branch
from
0e31df4
to
7c8248e
Compare
AndriySvyryd
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6525 (Allow connections string to be set/changed)
Fixes #8494 (Allow connection to be set/changed)
Fixes #8427 (Parameterless overloads of UseSqlServer, UseSqlite)