Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent dependents from being deleted when principal is detached #19379

Merged
merged 1 commit into from
Dec 22, 2019
Merged

Prevent dependents from being deleted when principal is detached #19379

merged 1 commit into from
Dec 22, 2019

Conversation

ajcvickers
Copy link
Member

Fixes #12590
Fixes #18982
Regression test for #16546

@AndriySvyryd
Copy link
Member

I think you meant "Prevent dependents from being deleted when principal is detached"

@ajcvickers ajcvickers merged commit f77c79b into master Dec 22, 2019
@ajcvickers ajcvickers deleted the AhHaCaughtYou1220 branch December 22, 2019 21:36
@shaulbehr
Copy link

Thanks for fixing! What release will this be in?

@ErikEJ
Copy link
Contributor

ErikEJ commented Dec 30, 2019

5.0 !

@ajcvickers ajcvickers changed the title Prevent dependents from being deleted when principal is deleted Prevent dependents from being deleted when principal is detached Dec 30, 2019
@ajcvickers ajcvickers mentioned this pull request Jan 10, 2020
Closed
@silvajpr
Copy link

Not acceptable to be release only on version 5!
By the way for me the Expected behavior is the related objects should KEEP / REMAIN the actual state - it shouldn’t be affected - it’s the beahvior of EF6 and EFCore 2.2.
Exemple: if the related object state is Added it should continue with that state!
For me doesn’t make sense to also detach the related objects.
Take this example: the principal exist in the DB and I simply want to remove it from the tracking changes, without any side effects in the related objects! (Maybe I have change some value and I don’t want it to be saved or another reason).
How can I do what I just explained?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ajcvickers @AndriySvyryd @shaulbehr @ErikEJ @silvajpr