Add DATEFROMPARTS function to SqlServer

[Marusyk]

Contributes #19237

Add DATEFROMPARTS function

Please review,
Thank you in advance

[maumar]

@Marusyk please fix the failing test, ideally convert the added tests to AssertQuery pattern and add tests for each method (datetime2, datetimeoffset, smalldatetime, time). Looks good otherwise

[Marusyk]

Could anyone suggest?
I have problem with TimeFromParts :

var count = context.Orders
     .Count(c => new TimeSpan(23, 59, 0) > EF.Functions.TimeFromParts(12, 12, 31, 5, 1));

it throws

System.InvalidOperationException
HResult=0x80131509
Message=An exception was thrown while attempting to evaluate the LINQ query parameter expression '(new TimeSpan(23, 59, 0) > EF.Functions.TimeFromParts(12, 12, 31, 5, 1))'.
Source=Microsoft.EntityFrameworkCore
StackTrace:
at Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.GetValue(Expression expression, String& parameterName) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\ParameterExtractingExpressionVisitor.cs:line 458
at Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.Evaluate(Expression expression, Boolean generateParameter) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\ParameterExtractingExpressionVisitor.cs:line 292
at Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.Visit(Expression expression) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\ParameterExtractingExpressionVisitor.cs:line 110
at System.Linq.Expressions.ExpressionVisitor.VisitLambda[T](Expression1 node) at System.Linq.Expressions.Expression1.Accept(ExpressionVisitor visitor)
at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
at Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.Visit(Expression expression) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\ParameterExtractingExpressionVisitor.cs:line 113
at System.Linq.Expressions.ExpressionVisitor.VisitUnary(UnaryExpression node)
at System.Linq.Expressions.UnaryExpression.Accept(ExpressionVisitor visitor)
at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
at Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.Visit(Expression expression) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\ParameterExtractingExpressionVisitor.cs:line 113
at System.Dynamic.Utils.ExpressionVisitorUtils.VisitArguments(ExpressionVisitor visitor, IArgumentProvider nodes)
at System.Linq.Expressions.ExpressionVisitor.VisitMethodCall(MethodCallExpression node)
at System.Linq.Expressions.MethodCallExpression.Accept(ExpressionVisitor visitor)
at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
at Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.Visit(Expression expression) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\ParameterExtractingExpressionVisitor.cs:line 113
at Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.ExtractParameters(Expression expression) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\ParameterExtractingExpressionVisitor.cs:line 84
at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.ExtractParameters(Expression query, IParameterValues parameterValues, IDiagnosticsLogger1 logger, Boolean parameterize, Boolean generateContextAccessors) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\QueryCompiler.cs:line 191 at Microsoft.EntityFrameworkCore.Query.Internal.QueryCompiler.Execute[TResult](Expression query) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\QueryCompiler.cs:line 90 at Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryProvider.Execute[TResult](Expression expression) in C:\Users\rmarusyk\source\EntityFrameworkCore\src\EFCore\Query\Internal\EntityQueryProvider.cs:line 79 at System.Linq.Queryable.Count[TSource](IQueryable1 source, Expression`1 predicate)
at Microsoft.EntityFrameworkCore.Query.NorthwindDbFunctionsQuerySqlServerTest.TimeFromParts_constant_compare() in C:\Users\rmarusyk\source\EntityFrameworkCore\test\EFCore.SqlServer.FunctionalTests\Query\NorthwindDbFunctionsQuerySqlServerTest.cs:line 1005

This exception was originally thrown at this call stack:
Microsoft.EntityFrameworkCore.SqlServerDbFunctionsExtensions.TimeFromParts(Microsoft.EntityFrameworkCore.DbFunctions, int, int, int, int, int) in SqlServerDbFunctionsExtensions.cs
Microsoft.EntityFrameworkCore.Query.Internal.ParameterExtractingExpressionVisitor.GetValue(System.Linq.Expressions.Expression, out string) in ParameterExtractingExpressionVisitor.cs

Inner Exception 1:
InvalidOperationException: The 'TimeFromParts' method is not supported because the query has switched to client-evaluation. Inspect the log to determine which query expressions are triggering client-evaluation.

[smitpatel]

EF.Functions.TimeFromParts(12, 12, 31, 5, 1)

Use at least one argument which is range variable from server side. (i.e. using c)

[maumar]

how about:

Orders.Select(o => new { o.OrderID, Time = EF.Functions.TimeFromParts(12, 12, 31, 5, o.OrderId % 60) })

[maumar]

@Marusyk thank you for the contribution!

[smitpatel]

refactor to set function name and return server type using case block.

[Marusyk]

Agree. Should I create a new PR for this?

[smitpatel]

I will do it. I may have small clean up tasks in other unrelated PRs too.