Nullability annotation for scaffolding

[roji]

Resubmission of #19321, reverted by cb686e849b448ebbafe9dfee5288d4610bc9823c.

Already reviewed and approved, @ajcvickers needs to confirm that it's working on his environment.

[ajcvickers]

@roji Still failing for me; IDE details below. Assume this is working on Linux with the same IDE? (By working I mean that you can open All.sln and rebuild all without error.)

JetBrains Rider 2019.3.1
Build #RD-193.5662.14, built on December 19, 2019
Licensed to Arthur Vickers
Subscription is active until March 19, 2020
Runtime version: 11.0.5+10-b520.17 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 4029M
Cores: 8
Registry: ide.tree.horizontal.default.autoscrolling=false, performance.watcher.sampling.interval.ms=200, show.diff.preview.as.editor.tab=true, ide.borderless.title.product=false, performance.watcher.unresponsive.interval.ms=1000, ide.tooltip.initialDelay.highlighter=0, search.everywhere.settings=true, parameter.info.max.visible.rows=10, ide.win.file.chooser.native=true, ide.borderless.title.project.path=false, search.everywhere.pattern.checking=false, ide.tooltip.initialDelay=0, ide.borderless.title.classpath=false, ide.require.transaction.for.model.changes=false, vcs.non.modal.commit.toggle.ui=false
Non-Bundled Plugins: com.intellij.resharper.HeapAllocationsViewer, com.microsoft.vso.idea, org.intellij.plugins.markdown

[roji]

Yeah, a full rebuild of All.sln works for me, both within Rider and on the command-line with dotnet build. Any chance you're using an older dotnet SDK (not 3.1.100) by any chance? Can you confirm whether dotnet build All.sln works?

JetBrains Rider 2019.3.1
Build #RD-193.5662.14, built on December 19, 2019
Licensed to Shay Rojansky
Subscription is active until March 22, 2020
Runtime version: 11.0.5+10-b520.17 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 5.3.0-24-generic
GC: ParNew, ConcurrentMarkSweep
Memory: 1450M
Cores: 12
Registry: ide.tree.horizontal.default.autoscrolling=false, performance.watcher.sampling.interval.ms=200, show.diff.preview.as.editor.tab=true, ide.borderless.title.product=false, performance.watcher.unresponsive.interval.ms=1000, ide.tooltip.initialDelay.highlighter=0, search.everywhere.settings=true, parameter.info.max.visible.rows=10, ide.win.file.chooser.native=true, ide.borderless.title.project.path=false, actionSystem.fix.alt.gr=false, search.everywhere.pattern.checking=false, ide.tooltip.initialDelay=0, ide.borderless.title.classpath=false, ide.require.transaction.for.model.changes=false, vcs.non.modal.commit.toggle.ui=false
Non-Bundled Plugins: 

[ajcvickers]

@roji

C:\aspnet\EntityFrameworkCore>dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   3.1.100
 Commit:    cd82f021f4

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18362
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\aspnet\EntityFrameworkCore\.dotnet\sdk\3.1.100\

Host (useful for support):
  Version: 3.1.0
  Commit:  65f04fb6db

.NET Core SDKs installed:
  3.1.100 [C:\aspnet\EntityFrameworkCore\.dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.1.0 [C:\aspnet\EntityFrameworkCore\.dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\aspnet\EntityFrameworkCore\.dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.0 [C:\aspnet\EntityFrameworkCore\.dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.1.0 [C:\aspnet\EntityFrameworkCore\.dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

C:\aspnet\EntityFrameworkCore>dotnet build
Microsoft (R) Build Engine version 16.4.0+e901037fe for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 25 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\AsyncSample\AsyncSample.csproj.
  Restore completed in 25 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\BatchingSample\BatchingSample.csproj.
  Restore completed in 25.02 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\AggregateFunctionSample\AggregateFunctionSample.csproj.
  Restore completed in 1.69 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\DateAndTimeSample\DateAndTimeSample.csproj.
  Restore completed in 1.8 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\CollationSample\CollationSample.csproj.
  Restore completed in 1.8 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\BulkInsertSample\BulkInsertSample.csproj.
  Restore completed in 33.91 ms for C:\aspnet\EntityFrameworkCore\benchmark\EFCore.Sqlite.Benchmarks\EFCore.Sqlite.Benchmarks.csproj.
  Restore completed in 33.97 ms for C:\aspnet\EntityFrameworkCore\benchmark\EF6.SqlServer.Benchmarks\EF6.SqlServer.Benchmarks.csproj.
  Restore completed in 33.98 ms for C:\aspnet\EntityFrameworkCore\benchmark\EFCore.Benchmarks\EFCore.Benchmarks.csproj.
  Restore completed in 33.98 ms for C:\aspnet\EntityFrameworkCore\benchmark\EF.Benchmarks.Shared\EF.Benchmarks.Shared.csproj.
  Restore completed in 33.97 ms for C:\aspnet\EntityFrameworkCore\benchmark\EFCore.SqlServer.Benchmarks\EFCore.SqlServer.Benchmarks.csproj.
  Restore completed in 18.69 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\InMemorySample\InMemorySample.csproj.
  Restore completed in 19.46 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\DirtyReadSample\DirtyReadSample.csproj.
  Restore completed in 1.53 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\ResultMetadataSample\ResultMetadataSample.csproj.
  Restore completed in 19.84 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\EncryptionSample\EncryptionSample.csproj.
  Restore completed in 1.71 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\InteropSample\InteropSample.csproj.
  Restore completed in 1.72 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\StreamingSample\StreamingSample.csproj.
  Restore completed in 1.87 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\ScalarFunctionSample\ScalarFunctionSample.csproj.
  Restore completed in 11.16 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\RegularExpressionSample\RegularExpressionSample.csproj.
  Restore completed in 1.65 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Abstractions\EFCore.Abstractions.csproj.
  Restore completed in 2.94 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Design\EFCore.Design.csproj.
  Restore completed in 1.97 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.InMemory\EFCore.InMemory.csproj.
  Restore completed in 2.24 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Relational\EFCore.Relational.csproj.
  Restore completed in 4.43 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Analyzers\EFCore.Analyzers.csproj.
  Restore completed in 2.85 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Sqlite.Core\EFCore.Sqlite.Core.csproj.
  Restore completed in 3.51 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Sqlite.NTS\EFCore.Sqlite.NTS.csproj.
  Restore completed in 10.16 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Tools\EFCore.Tools.csproj.
  Restore completed in 13.5 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Sqlite\EFCore.Sqlite.csproj.
  Restore completed in 11.37 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Cosmos\EFCore.Cosmos.csproj.
  Restore completed in 5.33 ms for C:\aspnet\EntityFrameworkCore\src\EFCore\EFCore.csproj.
  Restore completed in 5.82 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Proxies\EFCore.Proxies.csproj.
  Restore completed in 1.58 ms for C:\aspnet\EntityFrameworkCore\src\Microsoft.Data.Sqlite.Core\Microsoft.Data.Sqlite.Core.csproj.
  Restore completed in 3.24 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.SqlServer.NTS\EFCore.SqlServer.NTS.csproj.
  Restore completed in 2.01 ms for C:\aspnet\EntityFrameworkCore\src\Microsoft.Data.Sqlite\Microsoft.Data.Sqlite.csproj.
  Restore completed in 7.79 ms for C:\aspnet\EntityFrameworkCore\src\ef\ef.csproj.
  Restore completed in 8.34 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.SqlServer\EFCore.SqlServer.csproj.
  Restore completed in 19.52 ms for C:\aspnet\EntityFrameworkCore\test\ef.Tests\ef.Tests.csproj.
  Restore completed in 303.36 ms for C:\aspnet\EntityFrameworkCore\src\dotnet-ef\dotnet-ef.csproj.
  Restore completed in 451.8 ms for C:\aspnet\EntityFrameworkCore\test\dotnet-ef.Tests\dotnet-ef.Tests.csproj.
  Restore completed in 412.37 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.InMemory.FunctionalTests\EFCore.InMemory.FunctionalTests.csproj.
  Restore completed in 474.87 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Cosmos.FunctionalTests\EFCore.Cosmos.FunctionalTests.csproj.
  Restore completed in 470.8 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Cosmos.Tests\EFCore.Cosmos.Tests.csproj.
  Restore completed in 469.6 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Analyzers.Tests\EFCore.Analyzers.Test.csproj.
  Restore completed in 238.65 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.InMemory.Tests\EFCore.InMemory.Tests.csproj.
  Restore completed in 609.51 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.CrossStore.FunctionalTests\EFCore.CrossStore.FunctionalTests.csproj.
  Restore completed in 608.76 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Design.Tests\EFCore.Design.Tests.csproj.
  Restore completed in 239.03 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Relational.Specification.Tests\EFCore.Relational.Specification.Tests.csproj.
  Restore completed in 211.81 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Specification.Tests\EFCore.Specification.Tests.csproj.
  Restore completed in 296.25 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Proxies.Tests\EFCore.Proxies.Tests.csproj.
  Restore completed in 7.7 ms for C:\aspnet\EntityFrameworkCore\test\Microsoft.Data.Sqlite.Tests\Microsoft.Data.Sqlite.Tests.csproj.
  Restore completed in 298.02 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Relational.Tests\EFCore.Relational.Tests.csproj.
  Restore completed in 314.2 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Sqlite.FunctionalTests\EFCore.Sqlite.FunctionalTests.csproj.
  Restore completed in 311.12 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Sqlite.Tests\EFCore.Sqlite.Tests.csproj.
  Restore completed in 267.28 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.SqlServer.FunctionalTests\EFCore.SqlServer.FunctionalTests.csproj.
  Restore completed in 174.49 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Tests\EFCore.Tests.csproj.
  Restore completed in 290.56 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.SqlServer.Tests\EFCore.SqlServer.Tests.csproj.
  EFCore.Abstractions -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Abstractions\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Abstractions.dll
  ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef\Debug\net461\ef.exe
  ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef\Debug\netcoreapp2.0\ef.dll
  ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef\x86\Debug\net461\ef.exe
  EFCore.Analyzers -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Analyzers\Debug\netstandard2.0\Microsoft.EntityFrameworkCore.Analyzers.dll
  Microsoft.Data.Sqlite.Core -> C:\aspnet\EntityFrameworkCore\artifacts\bin\Microsoft.Data.Sqlite.Core\Debug\netstandard2.0\Microsoft.Data.Sqlite.dll
  ResultMetadataSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ResultMetadataSample\Debug\netcoreapp3.1\ResultMetadataSample.dll
  EncryptionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EncryptionSample\Debug\netcoreapp3.1\EncryptionSample.dll
  CollationSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\CollationSample\Debug\netcoreapp3.1\CollationSample.dll
  AggregateFunctionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\AggregateFunctionSample\Debug\netcoreapp3.1\AggregateFunctionSample.dll
  BatchingSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\BatchingSample\Debug\netcoreapp3.1\BatchingSample.dll
  BulkInsertSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\BulkInsertSample\Debug\netcoreapp3.1\BulkInsertSample.dll
  DirtyReadSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\DirtyReadSample\Debug\netcoreapp3.1\DirtyReadSample.dll
  AsyncSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\AsyncSample\Debug\netcoreapp3.1\AsyncSample.dll
  RegularExpressionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\RegularExpressionSample\Debug\netcoreapp3.1\RegularExpressionSample.dll
  InteropSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\InteropSample\Debug\netcoreapp3.1\InteropSample.dll
  StreamingSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\StreamingSample\Debug\netcoreapp3.1\StreamingSample.dll
  ScalarFunctionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ScalarFunctionSample\Debug\netcoreapp3.1\ScalarFunctionSample.dll
  InMemorySample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\InMemorySample\Debug\netcoreapp3.1\InMemorySample.dll
  Microsoft.Data.Sqlite.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\Microsoft.Data.Sqlite.Tests\Debug\netcoreapp3.1\Microsoft.Data.Sqlite.Tests.dll
  DateAndTimeSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\DateAndTimeSample\Debug\netcoreapp3.1\DateAndTimeSample.dll
  EF.Benchmarks.Shared -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EF.Benchmarks.Shared\Debug\netstandard2.0\EF.Benchmarks.Shared.dll
  EFCore -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.dll
  EFCore.Proxies -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Proxies\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Proxies.dll
  EFCore.InMemory -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.InMemory.dll
  EFCore.Cosmos -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Cosmos.dll
  EF.Benchmarks.Shared -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EF.Benchmarks.Shared\Debug\net461\EF.Benchmarks.Shared.dll
  EFCore.Relational -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Relational.dll
  EFCore.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Benchmarks\Debug\netcoreapp3.1\EFCore.Benchmarks.dll
  EFCore.SqlServer -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.SqlServer.dll
  dotnet-ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\dotnet-ef\Debug\netcoreapp3.1\dotnet-ef.dll
  dotnet-ef.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\dotnet-ef.Tests\Debug\netcoreapp3.1\dotnet-ef.Tests.dll
  EFCore.SqlServer.NTS -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.NTS\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite.dll
  EFCore.SqlServer.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.Benchmarks\Debug\netcoreapp3.1\EFCore.SqlServer.Benchmarks.dll
  EFCore.Specification.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Specification.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Specification.Tests.dll
  EFCore.Design -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Design\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Design.dll
  EF6.SqlServer.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EF6.SqlServer.Benchmarks\Debug\net461\EF6.SqlServer.Benchmarks.exe
  EFCore.Sqlite.Core -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Core\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Sqlite.dll
  ef.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef.Tests\Debug\netcoreapp3.1\ef.Tests.dll
  EFCore.Sqlite.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Benchmarks\Debug\netcoreapp3.1\EFCore.Sqlite.Benchmarks.dll
  EFCore.Sqlite.NTS -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.NTS\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Sqlite.NetTopologySuite.dll
  EFCore.Relational.Specification.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational.Specification.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Relational.Specification.Tests.dll
  EFCore.InMemory.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.InMemory.FunctionalTests.dll
  EFCore.Cosmos.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Cosmos.FunctionalTests.dll
  EFCore.Sqlite.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Sqlite.FunctionalTests.dll
  EFCore.SqlServer.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests.dll
  EFCore.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Tests.dll
  EFCore.CrossStore.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.CrossStore.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.CrossStore.FunctionalTests.dll
  EFCore.InMemory.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.InMemory.Tests.dll
  EFCore.Cosmos.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Cosmos.Tests.dll
  EFCore.Proxies.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Proxies.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Proxies.Tests.dll
  EFCore.Analyzers.Test -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Analyzers.Test\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Analyzers.Tests.dll
  EFCore.Relational.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Relational.Tests.dll
  EFCore.SqlServer.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.SqlServer.Tests.dll
  EFCore.Design.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Design.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Design.Tests.dll
  EFCore.Sqlite.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Sqlite.Tests.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:32.61

C:\aspnet\EntityFrameworkCore>git clean -xdf
Removing .dotnet/
Removing .idea/
Removing artifacts/

C:\aspnet\EntityFrameworkCore>dotnet build
Microsoft (R) Build Engine version 16.4.0+e901037fe for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 273.94 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\BatchingSample\BatchingSample.csproj.
  Restore completed in 273.96 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\AsyncSample\AsyncSample.csproj.
  Restore completed in 273.95 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\AggregateFunctionSample\AggregateFunctionSample.csproj.
  Restore completed in 8.26 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\DateAndTimeSample\DateAndTimeSample.csproj.
  Restore completed in 8.04 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\CollationSample\CollationSample.csproj.
  Restore completed in 8.17 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\BulkInsertSample\BulkInsertSample.csproj.
  Restore completed in 27.66 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\DirtyReadSample\DirtyReadSample.csproj.
  Restore completed in 26.48 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\InMemorySample\InMemorySample.csproj.
  Restore completed in 36.8 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\EncryptionSample\EncryptionSample.csproj.
  Restore completed in 12.64 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\InteropSample\InteropSample.csproj.
  Restore completed in 11.5 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\RegularExpressionSample\RegularExpressionSample.csproj.
  Restore completed in 18.57 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\ResultMetadataSample\ResultMetadataSample.csproj.
  Restore completed in 9.42 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\ScalarFunctionSample\ScalarFunctionSample.csproj.
  Restore completed in 9.68 ms for C:\aspnet\EntityFrameworkCore\samples\Microsoft.Data.Sqlite\StreamingSample\StreamingSample.csproj.
  Restore completed in 12.73 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Abstractions\EFCore.Abstractions.csproj.
  Restore completed in 22.45 ms for C:\aspnet\EntityFrameworkCore\src\dotnet-ef\dotnet-ef.csproj.
  Restore completed in 102.66 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Design\EFCore.Design.csproj.
  Restore completed in 112.53 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Analyzers\EFCore.Analyzers.csproj.
  Restore completed in 33.39 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.InMemory\EFCore.InMemory.csproj.
  Restore completed in 25.07 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Relational\EFCore.Relational.csproj.
  Restore completed in 235.64 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Cosmos\EFCore.Cosmos.csproj.
  Restore completed in 641.98 ms for C:\aspnet\EntityFrameworkCore\benchmark\EF6.SqlServer.Benchmarks\EF6.SqlServer.Benchmarks.csproj.
  Restore completed in 666.71 ms for C:\aspnet\EntityFrameworkCore\benchmark\EFCore.Benchmarks\EFCore.Benchmarks.csproj.
  Restore completed in 677.95 ms for C:\aspnet\EntityFrameworkCore\benchmark\EFCore.Sqlite.Benchmarks\EFCore.Sqlite.Benchmarks.csproj.
  Restore completed in 45 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Sqlite.Core\EFCore.Sqlite.Core.csproj.
  Restore completed in 63.11 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Sqlite.NTS\EFCore.Sqlite.NTS.csproj.
  Restore completed in 722.83 ms for C:\aspnet\EntityFrameworkCore\benchmark\EFCore.SqlServer.Benchmarks\EFCore.SqlServer.Benchmarks.csproj.
  Restore completed in 708.67 ms for C:\aspnet\EntityFrameworkCore\benchmark\EF.Benchmarks.Shared\EF.Benchmarks.Shared.csproj.
  Restore completed in 11.48 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Tools\EFCore.Tools.csproj.
  Restore completed in 207.84 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Proxies\EFCore.Proxies.csproj.
  Restore completed in 69.99 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.Sqlite\EFCore.Sqlite.csproj.
  Restore completed in 21.42 ms for C:\aspnet\EntityFrameworkCore\src\Microsoft.Data.Sqlite\Microsoft.Data.Sqlite.csproj.
  Restore completed in 21.24 ms for C:\aspnet\EntityFrameworkCore\src\Microsoft.Data.Sqlite.Core\Microsoft.Data.Sqlite.Core.csproj.
  Restore completed in 38.14 ms for C:\aspnet\EntityFrameworkCore\src\EFCore\EFCore.csproj.
  Restore completed in 152.24 ms for C:\aspnet\EntityFrameworkCore\src\ef\ef.csproj.
  Restore completed in 212.25 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.SqlServer.NTS\EFCore.SqlServer.NTS.csproj.
  Restore completed in 213.59 ms for C:\aspnet\EntityFrameworkCore\src\EFCore.SqlServer\EFCore.SqlServer.csproj.
  Restore completed in 381.05 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Cosmos.Tests\EFCore.Cosmos.Tests.csproj.
  Restore completed in 227.74 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.InMemory.FunctionalTests\EFCore.InMemory.FunctionalTests.csproj.
  Restore completed in 403.47 ms for C:\aspnet\EntityFrameworkCore\test\dotnet-ef.Tests\dotnet-ef.Tests.csproj.
  Restore completed in 421.75 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Cosmos.FunctionalTests\EFCore.Cosmos.FunctionalTests.csproj.
  Restore completed in 434.28 ms for C:\aspnet\EntityFrameworkCore\test\ef.Tests\ef.Tests.csproj.
  Restore completed in 401.29 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Analyzers.Tests\EFCore.Analyzers.Test.csproj.
  Restore completed in 372.41 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.CrossStore.FunctionalTests\EFCore.CrossStore.FunctionalTests.csproj.
  Restore completed in 374.37 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Design.Tests\EFCore.Design.Tests.csproj.
  Restore completed in 196.76 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Relational.Specification.Tests\EFCore.Relational.Specification.Tests.csproj.
  Restore completed in 189.33 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Specification.Tests\EFCore.Specification.Tests.csproj.
  Restore completed in 282.14 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.InMemory.Tests\EFCore.InMemory.Tests.csproj.
  Restore completed in 273.69 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Proxies.Tests\EFCore.Proxies.Tests.csproj.
  Restore completed in 270.68 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Sqlite.FunctionalTests\EFCore.Sqlite.FunctionalTests.csproj.
  Restore completed in 283.67 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Relational.Tests\EFCore.Relational.Tests.csproj.
  Restore completed in 289.48 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Sqlite.Tests\EFCore.Sqlite.Tests.csproj.
  Restore completed in 148.29 ms for C:\aspnet\EntityFrameworkCore\test\Microsoft.Data.Sqlite.Tests\Microsoft.Data.Sqlite.Tests.csproj.
  Restore completed in 212.08 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.Tests\EFCore.Tests.csproj.
  Restore completed in 275.95 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.SqlServer.FunctionalTests\EFCore.SqlServer.FunctionalTests.csproj.
  Restore completed in 262.24 ms for C:\aspnet\EntityFrameworkCore\test\EFCore.SqlServer.Tests\EFCore.SqlServer.Tests.csproj.
  ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef\Debug\net461\ef.exe
  EFCore.Analyzers -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Analyzers\Debug\netstandard2.0\Microsoft.EntityFrameworkCore.Analyzers.dll
  ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef\Debug\netcoreapp2.0\ef.dll
  Microsoft.Data.Sqlite.Core -> C:\aspnet\EntityFrameworkCore\artifacts\bin\Microsoft.Data.Sqlite.Core\Debug\netstandard2.0\Microsoft.Data.Sqlite.dll
  ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef\x86\Debug\net461\ef.exe
  EFCore.Abstractions -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Abstractions\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Abstractions.dll
  EF.Benchmarks.Shared -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EF.Benchmarks.Shared\Debug\netstandard2.0\EF.Benchmarks.Shared.dll
  EF.Benchmarks.Shared -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EF.Benchmarks.Shared\Debug\net461\EF.Benchmarks.Shared.dll
  dotnet-ef -> C:\aspnet\EntityFrameworkCore\artifacts\bin\dotnet-ef\Debug\netcoreapp3.1\dotnet-ef.dll
  InMemorySample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\InMemorySample\Debug\netcoreapp3.1\InMemorySample.dll
  RegularExpressionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\RegularExpressionSample\Debug\netcoreapp3.1\RegularExpressionSample.dll
  Microsoft.Data.Sqlite.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\Microsoft.Data.Sqlite.Tests\Debug\netcoreapp3.1\Microsoft.Data.Sqlite.Tests.dll
  DateAndTimeSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\DateAndTimeSample\Debug\netcoreapp3.1\DateAndTimeSample.dll
  BulkInsertSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\BulkInsertSample\Debug\netcoreapp3.1\BulkInsertSample.dll
  AggregateFunctionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\AggregateFunctionSample\Debug\netcoreapp3.1\AggregateFunctionSample.dll
  EFCore -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.dll
  DirtyReadSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\DirtyReadSample\Debug\netcoreapp3.1\DirtyReadSample.dll
  InteropSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\InteropSample\Debug\netcoreapp3.1\InteropSample.dll
  ScalarFunctionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ScalarFunctionSample\Debug\netcoreapp3.1\ScalarFunctionSample.dll
  EF6.SqlServer.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EF6.SqlServer.Benchmarks\Debug\net461\EF6.SqlServer.Benchmarks.exe
  dotnet-ef.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\dotnet-ef.Tests\Debug\netcoreapp3.1\dotnet-ef.Tests.dll
  AsyncSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\AsyncSample\Debug\netcoreapp3.1\AsyncSample.dll
  BatchingSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\BatchingSample\Debug\netcoreapp3.1\BatchingSample.dll
  CollationSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\CollationSample\Debug\netcoreapp3.1\CollationSample.dll
  EncryptionSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EncryptionSample\Debug\netcoreapp3.1\EncryptionSample.dll
  ResultMetadataSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ResultMetadataSample\Debug\netcoreapp3.1\ResultMetadataSample.dll
  StreamingSample -> C:\aspnet\EntityFrameworkCore\artifacts\bin\StreamingSample\Debug\netcoreapp3.1\StreamingSample.dll
  EFCore.InMemory -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.InMemory.dll
  EFCore.Cosmos -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Cosmos.dll
  EFCore.Proxies -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Proxies\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Proxies.dll
  EFCore.Relational -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Relational.dll
  EFCore.Sqlite.Core -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Core\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Sqlite.dll
  EFCore.Design -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Design\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Design.dll
  EFCore.Sqlite.NTS -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.NTS\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.Sqlite.NetTopologySuite.dll
  EFCore.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Benchmarks\Debug\netcoreapp3.1\EFCore.Benchmarks.dll
  EFCore.Sqlite.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Benchmarks\Debug\netcoreapp3.1\EFCore.Sqlite.Benchmarks.dll
  EFCore.SqlServer -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.SqlServer.dll
  EFCore.Specification.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Specification.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Specification.Tests.dll
  EFCore.InMemory.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.InMemory.FunctionalTests.dll
  EFCore.SqlServer.NTS -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.NTS\Debug\netstandard2.1\Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite.dll
  EFCore.Relational.Specification.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational.Specification.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Relational.Specification.Tests.dll
  EFCore.SqlServer.Benchmarks -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.Benchmarks\Debug\netcoreapp3.1\EFCore.SqlServer.Benchmarks.dll
  EFCore.Cosmos.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Cosmos.FunctionalTests.dll
  ef.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\ef.Tests\Debug\netcoreapp3.1\ef.Tests.dll
  EFCore.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Tests.dll
  EFCore.SqlServer.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests.dll
  EFCore.InMemory.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.InMemory.Tests.dll
  EFCore.Sqlite.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Sqlite.FunctionalTests.dll
  EFCore.Analyzers.Test -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Analyzers.Test\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Analyzers.Tests.dll
  EFCore.Proxies.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Proxies.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Proxies.Tests.dll
  EFCore.CrossStore.FunctionalTests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.CrossStore.FunctionalTests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.CrossStore.FunctionalTests.dll
  EFCore.Relational.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Relational.Tests.dll
  EFCore.Cosmos.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Cosmos.Tests.dll
  EFCore.Sqlite.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Sqlite.Tests.dll
  EFCore.SqlServer.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.SqlServer.Tests.dll
  EFCore.Design.Tests -> C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Design.Tests\Debug\netcoreapp3.1\Microsoft.EntityFrameworkCore.Design.Tests.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:47.08

[roji]

@ajcvickers so I understand correctly, you can build this branch from the cmdline, but when you build it from Rider you get compilation errors? That could indicate that maybe you're using some special dotnet CLI or something, can you please check out File->Settings->Build, Execution, Deployment->Toolset and Build? The important bit is probably the .NET Core CLI executable path, which in my case is /usr/share/dotnet/dotnet (the global/system-wide place for .NET SDK installations, should be the analogous path in Windows...).

[roji]

@aspnet/efteam can someone else confirm that they can properly build this branch from an up-to-date VS?

[ajcvickers]

@roji But when using our build system we install and use a local SDK. Hence:

.NET Core SDKs installed:
  3.1.100 [C:\aspnet\EntityFrameworkCore\.dotnet\sdk]

We shouldn't be using whatever is installed on the machine.

[ajcvickers]

@roji I think I figured it out somewhat. The clue was in that settings page. Instead of using the auto-detected MSBuild (which came from VS) I changed it to use the local MSBuild:

Now it builds without error for me!

[roji]

The clue was in that settings page. Instead of using the auto-detected MSBuild (which came from VS) I changed it to use the local MSBuild

Oh weird... So the VS-provided MSBuild is too old or something? 🤷‍♂

We shouldn't be using whatever is installed on the machine.

You're right - up until 3.1 I my EF's Rider settings were pointing to the EF-provided dotnet SDK, but since for now we're at vanilla 3.1 it seems a bit easier to just hack on EF as if it were just any normal open source project out there :) Until we pin to some other SDK that is.

Anyway thanks for looking into it, will merge now.