Use value converters when storing in the in-memory database #19417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also enable tests which are skipped with #14042 |
ajcvickers
force-pushed
the
InsertingAManBehindTheCurtain1226
branch
from
0ff9470
to
c97473b
Compare
|
@smitpatel Done. Was hoping we could get away without snapshotting values on the way out, but I guess that was wishful thinking. |
There was a curtain, but no man. Now there is a man behind the curtain. Let's hope he doesn't fumble the data... Fixes #14042
smitpatel
reviewed
Dec 29, 2019
src/EFCore.InMemory/Query/Internal/InMemoryExpressionTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
ajcvickers
force-pushed
the
InsertingAManBehindTheCurtain1226
branch
from
c97473b
to
912a189
Compare
smitpatel
reviewed
Dec 29, 2019
smitpatel
reviewed
Dec 29, 2019
src/EFCore/ChangeTracking/Internal/RelationshipSnapshotFactoryFactory.cs
Show resolved
Hide resolved
smitpatel
approved these changes
Dec 29, 2019
bricelam
reviewed
Jan 3, 2020
| { | ||
| base.Mutation_of_tracked_values_does_not_mutate_values_in_store(); | ||
| } | ||
|
|
This was referenced Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a curtain, but no man.
Now there is a man behind the curtain.
Let's hope he doesn't fumble the data...
Fixes #14042