Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata: Add Getter/Setter support for indexed properties #19440

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Metadata: Add Getter/Setter support for indexed properties #19440

merged 1 commit into from
Jan 1, 2020

Conversation

smitpatel
Copy link
Member

Part of #13610

@smitpatel smitpatel force-pushed the smit/indexer branch 3 times, most recently from 9f7ae44 to 9895e5c Compare December 31, 2019 21:42
AndriySvyryd
AndriySvyryd requested changes Dec 31, 2019
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add IConventionEntityType and IMutableEntityType tests that add valid and invalid indexer properties, indexer navigations and indexer skip navigations.

AndriySvyryd
AndriySvyryd requested changes Dec 31, 2019
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing a test for NonIndexerEntityType

@smitpatel
Copy link
Member Author

Updated.

@smitpatel smitpatel merged commit ddf496f into master Jan 1, 2020
@smitpatel smitpatel deleted the smit/indexer branch January 1, 2020 10:58
@ajcvickers ajcvickers mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @AndriySvyryd