Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add tests for indexer properties #19502

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Query: Add tests for indexer properties #19502

merged 1 commit into from
Feb 6, 2020

Conversation

smitpatel
Copy link
Member

Resolves #19495
Resolves #19458

Changes

  • Sort indexer properties along with shadow properties during model diff for column ordering in a table
  • Updated documentation of IndexedProperty
  • Add IndexedProperty fluent API to owned navigation builder
  • Re-attach indexer property correctly after detach

@maumar
Copy link
Contributor

maumar commented Jan 8, 2020 •
edited
Loading

testing part looks good but I would like someone (i.e. @AndriySvyryd ) to take a look at the metadata changes

@smitpatel smitpatel force-pushed the smit/issue19458 branch 2 times, most recently from 1711290 to b2c7058 Compare February 6, 2020 19:21
@smitpatel smitpatel force-pushed the smit/issue19458 branch 2 times, most recently from 075c0dc to 5f7394e Compare February 6, 2020 19:41
@smitpatel
Query: Add tests for indexer properties
b09024e 
Resolves #19495
Resolves #19458

Changes
- Sort indexer properties along with shadow properties during model diff for column ordering in a table
- Updated documentation of IndexedProperty
- Add IndexedProperty fluent API to owned navigation builder
- Re-attach indexer property correctly after detach
@smitpatel smitpatel merged commit f98509f into master Feb 6, 2020
@smitpatel smitpatel deleted the smit/issue19458 branch February 6, 2020 20:56
@ajcvickers ajcvickers mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumar maumar maumar left review comments

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seeding: Enable indexer properties to be seeded using concrete type Query: Testing indexed properties
3 participants
@smitpatel @maumar @AndriySvyryd