Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract INavigationBase #19504

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Extract INavigationBase #19504

merged 1 commit into from
Jan 8, 2020

Conversation

AndriySvyryd
Copy link
Member

Part of #19003

@smitpatel
Copy link
Member

Stackoverflow 😢

@@ -398,7 +398,7 @@ private BlockExpression AddIncludes(BlockExpression shaperBlock)
INavigation navigation,
INavigation inverseNavigation,
Action<TIncludingEntity, TIncludedEntity> fixup,
Action<TIncludingEntity> initialize)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this if not used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it must have the same number of parameters as IncludeCollection to make the code simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants