Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments on setup methods #19654

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Update comments on setup methods #19654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/EFCore/DbContextOptionsBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@ public virtual DbContextOptionsBuilder UseModel([NotNull] IModel model)
/// for logging done by this context.
/// </para>
/// <para>
/// There is no need to call this method when using one of the 'AddDbContext' methods.
/// 'AddDbContext' will ensure that the <see cref="ILoggerFactory" /> used by EF is obtained from the
/// application service provider.
/// There is no need to call this method when using one of the 'AddDbContext' methods, including 'AddDbContextPool'.
/// These methods ensure that the <see cref="ILoggerFactory" /> used by EF is obtained from the application service provider.
/// </para>
/// <para>
/// This method cannot be used if the application is setting the internal service provider
Expand Down Expand Up @@ -399,7 +398,8 @@ public virtual DbContextOptionsBuilder UseInternalServiceProvider([CanBeNull] IS

/// <summary>
/// Sets the <see cref="IServiceProvider" /> from which application services will be obtained. This
/// is done automatically when using 'AddDbContext', so it is rare that this method needs to be called.
/// is done automatically when using 'AddDbContext' or 'AddDbContextPool',
/// so it is rare that this method needs to be called.
/// </summary>
/// <param name="serviceProvider"> The service provider to be used. </param>
/// <returns> The same builder instance so that multiple calls can be chained. </returns>
Expand Down