Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TINY] Enabling tests for #19020 - Parameter based optimization tries to group by constant #19684

Merged
merged 1 commit into from
Jan 23, 2020
Merged

[TINY] Enabling tests for #19020 - Parameter based optimization tries to group by constant #19684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/EFCore.InMemory.FunctionalTests/Query/GearsOfWarQueryInMemoryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,11 @@ public override Task Select_subquery_projecting_single_constant_inside_anonymous
{
return base.Select_subquery_projecting_single_constant_inside_anonymous(async);
}

[ConditionalTheory(Skip = "issue #19683")]
public override Task Group_by_on_StartsWith_with_null_parameter_as_argument(bool async)
{
return base.Group_by_on_StartsWith_with_null_parameter_as_argument(async);
}
}
}
5 changes: 3 additions & 2 deletions test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7105,15 +7105,16 @@ public virtual Task Group_by_with_aggregate_max_on_entity_type(bool async)
.Select(g => new { g.Key, Aggregate = g.Max() })));
}

[ConditionalTheory(Skip = "issue #19020")]
[ConditionalTheory]
[MemberData(nameof(IsAsyncData))]
public virtual Task Group_by_on_StartsWith_with_null_parameter_as_argument(bool async)
{
var prm = (string)null;

return AssertQueryScalar(
async,
ss => ss.Set<Gear>().GroupBy(g => g.FullName.StartsWith(prm)).Select(g => g.Key));
ss => ss.Set<Gear>().GroupBy(g => g.FullName.StartsWith(prm)).Select(g => g.Key),
ss => ss.Set<Gear>().Select(g => false));
}

[ConditionalTheory]
Expand Down
4 changes: 3 additions & 1 deletion test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7043,7 +7043,9 @@ public override async Task Group_by_on_StartsWith_with_null_parameter_as_argumen
await base.Group_by_on_StartsWith_with_null_parameter_as_argument(async);

AssertSql(
@"");
@"SELECT CAST(0 AS bit)
FROM [Gears] AS [g]
WHERE [g].[Discriminator] IN (N'Gear', N'Officer')");
}

public override async Task Group_by_with_having_StartsWith_with_null_parameter_as_argument(bool async)
Expand Down