Fix to #18147 - Where bool column needs to convert to equality when value converter is applied #19689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fix for EF.Property access & indexer properties. |
|
new version up |
|
ping |
AndriySvyryd
approved these changes
Feb 4, 2020
…alue converter is applied Fix is to detect bool columns with value converters (upon initial translation) and apply comparison with constant true (with the same mapping). Also, we need to recognize this pattern during SqlExpression optimization, so that it' doesn't get simplified from 'a == true' to 'a' Resolves #18147
smitpatel
reviewed
Feb 5, 2020
| : TranslationFailed(memberExpression.Expression, Visit(memberExpression.Expression), out var sqlInnerExpression) | ||
| ? null | ||
| : _memberTranslatorProvider.Translate(sqlInnerExpression, memberExpression.Member, memberExpression.Type); | ||
| return CompensateForValueConverter( |
There was a problem hiding this comment.
Should wrap only result of TryBindMember. MemberTranslatorProvider should take care of itself.
smitpatel
reviewed
Feb 5, 2020
| : Dependencies.MemberTranslatorProvider.Translate(sqlInnerExpression, memberExpression.Member, memberExpression.Type); | ||
| } | ||
| return CompensateForValueConverter( | ||
| TryBindMember(memberExpression.Expression, MemberIdentity.Create(memberExpression.Member), out var result) |
|
This too broad fix which generates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is to detect bool columns with value converters (upon initial translation) and apply comparison with constant true (with the same mapping). Also, we need to recognize this pattern during SqlExpression optimization, so that it' doesn't get simplified from 'a == true' to 'a'
Resolves #18147