[release/3.1] SQLite Spatial: Find SpatiaLite in framework-dependent deployments #19701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bricelam I filled out a skeleton servicing template. Can you you add/correct as needed, and say something about risk? |
ajcvickers
approved these changes
Jan 27, 2020
|
@bricelam Can you take an initial stab at filling out the servicing template here? |
|
@bricelam Approved by Tactics and branches are open; let's try to get this merged today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loading SpatiaLite can fail in framework-dependent deployments. This prevents EF SQLite applications from using spatial types.
Customer Impact
Application crashes when attempting to use SpatiaLite.
How found
Reported by multiple customers.
Test coverage
We need better testing in this area. It's hard to do with automated testing of dotnet publish, but we are looking at what we can do in CTI tests.
Regression?
No.
Risk
Very low; we just check for the library in one more place before abandoning the search.
Fixes #15691