Fix to #18211 - Throw better exception for Last without order by #19773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maumar Can you take a look at this PR? Looks decent to me, but it is query. ;-) |
maumar
reviewed
Feb 4, 2020
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindAggregateOperatorsQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Feb 4, 2020
|
some minor changes, looks good otherwise! |
smitpatel
reviewed
Feb 5, 2020
test/EFCore.Specification.Tests/Query/NorthwindAggregateOperatorsQueryTestBase.cs
Show resolved
Hide resolved
smitpatel
reviewed
Feb 6, 2020
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
approved these changes
Feb 6, 2020
|
Squashed and good to go! |
|
@Muppets - Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Not great at exception message text at the best of times. I went with:
When performing a Last() operation, you must include an OrderBy clause.
I'm open to suggestions on better text!
Fixes #18211