Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Cleanup in language processing #19823

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Query: Cleanup in language processing #19823

merged 1 commit into from
Feb 7, 2020

Conversation

smitpatel
Copy link
Member

No description provided.

@smitpatel smitpatel requested review from andrefboliveira and a team and removed request for andrefboliveira February 7, 2020 01:01
@maumar
Copy link
Contributor

maumar commented Feb 7, 2020

@roji

@roji
Copy link
Member

roji commented Feb 7, 2020 •
edited
Loading

This removes the simplification from string.Compare(a, b) == 0 to a == b (which impacts perf), and the correspond case-insensitive simplification. It seems more conducive to working together to first finish explaining why this is necessary before doing this (conversation in #16092).

@smitpatel
Copy link
Member Author

I replied to #16092. It needs to be fixed for perf anyway since this simplification did not solve anything for C#. This creates additional code to maintain which is covered by other issue anyway.

@smitpatel
Copy link
Member Author

@ajcvickers - I need sign-off for this PR.

@smitpatel smitpatel merged commit ac341b0 into master Feb 7, 2020
@smitpatel smitpatel deleted the smit/cleanup2 branch February 7, 2020 19:35
@ajcvickers ajcvickers mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitpatel @maumar @roji