ReplacingEV uses two arrays instead of dictionary #19858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReplacingExpressionVisitor held original and replacement expressions in a dictionary. Unfortunately that means hash code calculation occurs exponentially, as each TryGetValue on the dictionary must traverse the entire tree. Replaced with two lists and a simple Equals check, which is much faster. Fixes #19737
smitpatel
reviewed
Feb 10, 2020
| } | ||
|
|
||
| public ReplacingExpressionVisitor([NotNull] IDictionary<Expression, Expression> replacements) | ||
| public ReplacingExpressionVisitor([NotNull] Expression[] originals, [NotNull] Expression[] replacements) |
There was a problem hiding this comment.
Yep. We could leave the previous constructor and build arrays out of the keys/values.
AndriySvyryd
approved these changes
Feb 10, 2020
roji
added a commit
that referenced
this pull request
Feb 10, 2020
ReplacingExpressionVisitor held original and replacement expressions in a dictionary. Unfortunately that means hash code calculation occurs exponentially, as each TryGetValue on the dictionary must traverse the entire tree. Replaced with two lists and a simple Equals check, which is much faster. Fixes #19737 (cherry picked from commit 7c9fc8a)
roji
added a commit
that referenced
this pull request
Feb 14, 2020
ReplacingExpressionVisitor held original and replacement expressions in a dictionary. Unfortunately that means hash code calculation occurs exponentially, as each TryGetValue on the dictionary must traverse the entire tree. Replaced with two lists and a simple Equals check, which is much faster. Fixes #19737 (cherry picked from commit 7c9fc8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReplacingExpressionVisitor held original and replacement expressions in a dictionary. Unfortunately that means hash code calculation occurs exponentially, as each TryGetValue on the dictionary must traverse the entire tree.
Replaced with two lists and a simple Equals check, which is much faster.
Fixes #19737