Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IModelFinalizedConvention to IModelFinalizingConvention #19872

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

AndriySvyryd
Copy link
Member

Introduce IModelFinalizedConvention that don't change the model

Part of #12846

Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ajcvickers
Copy link
Member

@AndriySvyryd Motivation for changing the name here? Is it purely to make the name more "correct" or do we functionally need to change?

@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented Feb 11, 2020

@ajcvickers We need to have conventions that run after the OnModelFinalized conventions for two reasons:

  1. Moving ValidatingConvention there will make it easier for providers and users to add conventions as they need to run before ValidatingConvention
  2. We need a hook for model transformations that don't change the configuration, such as adding a relational model or switching to a runtime-optimized implementation.

Introduce IModelFinalizedConvention that don't change the model

Part of #12846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants