Query: Combine queryable method processing expression visitors #19885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces QueryableMethodNormalizingExpressionVisitor which - Extract query metadata methods - Convert from enumerable to queryable - Convert List.Contains to queryable Contains - Flatten GroupJoin-SelectMany Nav expansion now calls this method on query filter/ defining query Resolves #19708 Part of #18923
| query = new InvocationExpressionRemovingExpressionVisitor().Visit(query); | ||
|
|
||
| query = NormalizeQueryableMethodCall(query); |
There was a problem hiding this comment.
That method is being used from nav expansion.
There was a problem hiding this comment.
Ok, still doesn't explain the blank lines around it
There was a problem hiding this comment.
Iteration 1. I will remove all blanks lines when full clean up of this visitor is done, promise!
AndriySvyryd
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces QueryableMethodNormalizingExpressionVisitor which
Nav expansion now calls this method on query filter/ defining query
Resolves #19708
Part of #18923