[release/3.1] Cosmos: Visit sibling includes when encountering an owned collections #19901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
changed the title
smitpatel
approved these changes
Feb 13, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19159
Description
When querying owned entity types that have owned collections as well as owned references the owned references are not included in the results.
Customer Impact
Query returns incomplete results. There's no workaround.
How found
Reported by multiple customers.
Test coverage
We did not have test coverage for this specific scenario. This PR includes new coverage.
Regression?
No.
Risk
Low. Affects only processing of owned references sibling to owned collections.
Also, fix is on by default, but quirk switch is present to revert back to old behavior.