Fix to #19900 - Query/Test: add automatic null propagation for AssertQuery baselines (part1) #19902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
automatic_null_propagation_part1
branch
2 times, most recently
from
49fddb7
to
fe9823c
Compare
|
Typo: AssertQuery everywhere. |
AndriySvyryd
approved these changes
Feb 13, 2020
maumar
changed the title
…Query baselines (part1) Added visitor that injects Maybe methods for all non-scalar member accesses. Also refactored Maybe methods to be more composible and so that when used manually, they don't require type arguments to be specified.
maumar
force-pushed
the
automatic_null_propagation_part1
branch
from
fe9823c
to
7400943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added visitor that injects Maybe methods for all non-scalar member accesses.
Also refactored Maybe methods to be more composible and so that when used manually, they don't require type arguments to be specified.